Skip to content

fix(envoy-client): drop trailing frames for completed HTTP requests - #5936

Merged
MasterPtato merged 2 commits into
mainfrom
fix/envoy-client-trailing-http-frames
Oct 30, 2026
Merged

MasterPtato merged 2 commits into
mainfrom
fix/envoy-client-trailing-http-frames

Conversation

@MasterPtato

@MasterPtato MasterPtato commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor
  • Remember HTTP requests the actor finished for 10 seconds and silently drop continuation frames the gateway sent before it saw the response end, instead of answering them with an unknown-request abort.
  • Release a request's routing state once both the upload and the response are finished.
  • Adds an actor HTTP stream test harness and covers the trailing-frame case.

@railway-app

railway-app Bot commented Oct 29, 2026

Copy link
Copy Markdown

🚅 Deployed to the rivet-pr-5936 environment in rivet-frontend

8 services not affected by this PR
  • mcp-hub
  • frontend-cloud-ee
  • kitchen-sink
  • website
  • sentry-tunnel
  • frontend-inspector
  • frontend-cloud
  • ladle

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

📟 Pip-Boy · c1838f4

📦 Packages

Skipped: this PR doesn't change any published package.

🧹 Rust dependencies · cargo deny + cargo shear

check new in this PR fixed existing on base
advisories ✅ 0 0 40
licenses ✅ 0 0 0
sources ✅ 0 0 0
bans ✅ 0 0 0
unused ✅ 0 0 292

🦀 Binaries · publish Dockerfiles, --release

Base: main@4a2cd74, the newest main commit with native builds before the merge base. Size changes merged to main since then show up here too.

artifact npm @latest base this PR Δ vs base
engine linux-x64-musl 93.9 MB 93.9 MB 93.9 MB 0
rivetkit-napi linux-x64-gnu 44.0 MB 44.0 MB 44.0 MB +8.1 KB (+0.0%)

⏱ Timing

job wall time slowest step
changes 18s checkout · 14s
zizmor 10s checkout · 3s
hygiene 59s checkout · 15s
native · rivetkit-napi · linux-x64-gnu 5m43s Build with the publish Dockerfile · 5m21s
native · engine · linux-x64-musl 13m58s Build with the publish Dockerfile · 13m44s
⏭ footprint — skipped
⏭ self-test — skipped
report 19s Write the comment and run summary · 5s
🔭 Full CI trace for this commit

One OpenTelemetry trace of Rust CI, frontend, and Pip-Boy for c1838f4: every job and step, with the sizes above attached. Run after CI finishes.

pnpm install --frozen-lockfile --filter 'pipboy...'
pnpm --filter pipboy pipboy trace --sha c1838f41983ee7dfb54f1b53236cadac25d8829c

Add --otlp <url> to send it to any OTLP/HTTP collector.

Agent instruction: From a rivet-dev/rivet checkout, run the commands above, then read the trace file the last command prints. List the slowest jobs and steps and explain where CI time went.

@MasterPtato
MasterPtato force-pushed the fix/envoy-client-trailing-http-frames branch from eafc313 to c1838f4 Compare October 30, 2026 20:50
@MasterPtato
MasterPtato force-pushed the fix/depot-client-stale-read-cache branch from 18bb8df to 09167e4 Compare October 30, 2026 20:50
Base automatically changed from fix/depot-client-stale-read-cache to main October 30, 2026 20:51
@MasterPtato
MasterPtato merged commit c1838f4 into main Oct 30, 2026
5 of 17 checks passed
@MasterPtato
MasterPtato deleted the fix/envoy-client-trailing-http-frames branch October 30, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant