Skip to content

chore(logging): reduce expected runtime error noise - #5937

Merged
MasterPtato merged 1 commit into
mainfrom
chore/reduce-runtime-error-noise
Oct 30, 2026
Merged

MasterPtato merged 1 commit into
mainfrom
chore/reduce-runtime-error-noise

Conversation

@MasterPtato

Copy link
Copy Markdown
Contributor
  • Lower expected, recoverable runtime events (websocket closes, dropped hook replies, unavailable websocket sends, serializeState timeouts, legacy KV import failures) from error to warn or debug.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

📟 Pip-Boy · cb2b51c

📦 Packages

Skipped: this PR doesn't change any published package.

🧹 Rust dependencies · cargo deny + cargo shear

check new in this PR fixed existing on base
advisories ✅ 0 0 40
licenses ✅ 0 0 0
sources ✅ 0 0 0
bans ✅ 0 0 0
unused ✅ 0 0 292

🦀 Binaries · publish Dockerfiles, --release

Base: main@4a2cd74, the newest main commit with native builds before the merge base. Size changes merged to main since then show up here too.

artifact npm @latest base this PR Δ vs base
engine linux-x64-musl 93.9 MB 93.9 MB 93.9 MB 0
rivetkit-napi linux-x64-gnu 44.0 MB 44.0 MB 44.0 MB +7.6 KB (+0.0%)

⏱ Timing

job wall time slowest step
changes 17s checkout · 14s
zizmor 9s checkout · 3s
hygiene 57s checkout · 14s
native · rivetkit-napi · linux-x64-gnu 5m27s Build with the publish Dockerfile · 5m12s
native · engine · linux-x64-musl 12m45s Build with the publish Dockerfile · 12m29s
⏭ self-test — skipped
⏭ footprint — skipped
report 16s Write the comment and run summary · 5s
🔭 Full CI trace for this commit

One OpenTelemetry trace of Rust CI, frontend, and Pip-Boy for cb2b51c: every job and step, with the sizes above attached. Run after CI finishes.

pnpm install --frozen-lockfile --filter 'pipboy...'
pnpm --filter pipboy pipboy trace --sha cb2b51cb794b08cf3a92ce5eac068aeb9f4b321f

Add --otlp <url> to send it to any OTLP/HTTP collector.

Agent instruction: From a rivet-dev/rivet checkout, run the commands above, then read the trace file the last command prints. List the slowest jobs and steps and explain where CI time went.

@MasterPtato
MasterPtato force-pushed the chore/reduce-runtime-error-noise branch from be43963 to cb2b51c Compare October 30, 2026 20:50
@MasterPtato
MasterPtato force-pushed the fix/envoy-client-trailing-http-frames branch from eafc313 to c1838f4 Compare October 30, 2026 20:50
Base automatically changed from fix/envoy-client-trailing-http-frames to main October 30, 2026 20:51
@MasterPtato
MasterPtato merged commit cb2b51c into main Oct 30, 2026
6 of 19 checks passed
@MasterPtato
MasterPtato deleted the chore/reduce-runtime-error-noise branch October 30, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants