Skip to content

fix(sqlite): classify operation error logs - #5938

Merged
MasterPtato merged 1 commit into
mainfrom
fix/sqlite-classify-operation-error-logs
Oct 30, 2026
Merged

MasterPtato merged 1 commit into
mainfrom
fix/sqlite-classify-operation-error-logs

Conversation

@MasterPtato

Copy link
Copy Markdown
Contributor
  • Log SQLite operations whose result is indeterminate after an envoy disconnect as a compact debug event instead of an error, since the transport already reports the disconnect.
  • Adds a test for the classification.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

📟 Pip-Boy · 3ddc9ef

📦 Packages

Skipped: this PR doesn't change any published package.

🧹 Rust dependencies · cargo deny + cargo shear

check new in this PR fixed existing on base
advisories ✅ 0 0 40
licenses ✅ 0 0 0
sources ✅ 0 0 0
bans ✅ 0 0 0
unused ✅ 0 0 292

🦀 Binaries · publish Dockerfiles, --release

Base: main@4a2cd74, the newest main commit with native builds before the merge base. Size changes merged to main since then show up here too.

artifact npm @latest base this PR Δ vs base
engine linux-x64-musl 93.9 MB 93.9 MB 93.9 MB 0
rivetkit-napi linux-x64-gnu 44.0 MB 44.0 MB 44.1 MB +15.0 KB (+0.0%)

⏱ Timing

job wall time slowest step
zizmor 11s checkout · 3s
changes 19s checkout · 14s
native · engine · linux-x64-musl 13m04s Build with the publish Dockerfile · 12m51s
native · rivetkit-napi · linux-x64-gnu 5m10s Build with the publish Dockerfile · 4m56s
hygiene 59s checkout · 14s
⏭ footprint — skipped
⏭ self-test — skipped
report 17s Write the comment and run summary · 5s
🔭 Full CI trace for this commit

One OpenTelemetry trace of Rust CI, frontend, and Pip-Boy for 3ddc9ef: every job and step, with the sizes above attached. Run after CI finishes.

pnpm install --frozen-lockfile --filter 'pipboy...'
pnpm --filter pipboy pipboy trace --sha 3ddc9ef69a0e1a8eafed549f605d4827d6eca25d

Add --otlp <url> to send it to any OTLP/HTTP collector.

Agent instruction: From a rivet-dev/rivet checkout, run the commands above, then read the trace file the last command prints. List the slowest jobs and steps and explain where CI time went.

@MasterPtato
MasterPtato force-pushed the chore/reduce-runtime-error-noise branch from be43963 to cb2b51c Compare October 30, 2026 20:50
@MasterPtato
MasterPtato force-pushed the fix/sqlite-classify-operation-error-logs branch from 4bc4e7e to 3ddc9ef Compare October 30, 2026 20:50
Base automatically changed from chore/reduce-runtime-error-noise to main October 30, 2026 20:51
@MasterPtato
MasterPtato merged commit 3ddc9ef into main Oct 30, 2026
13 of 24 checks passed
@MasterPtato
MasterPtato deleted the fix/sqlite-classify-operation-error-logs branch October 30, 2026 20:51

This branch had an error being deployed

24 in progress and 1 failed deployments
rivet-frontend / engine-ee-pr-1535 — 3ddc9ef6 Deployed Oct 31, 2026 by railway-app[bot]
rivet-frontend / engine-ee-pr-1475 — 3ddc9ef6 Deployed Oct 30, 2026 by railway-app[bot]
rivet-frontend / dynamic-apps-pr-296 — 3ddc9ef6 Deployed Oct 30, 2026 by railway-app[bot]
rivet-frontend / engine-ee-pr-1366 — 3ddc9ef6 Deployed Oct 30, 2026 by railway-app[bot]
rivet-frontend / engine-ee-pr-1498 — 3ddc9ef6 Deployed Oct 30, 2026 by railway-app[bot]
rivet-frontend / preview — 3ddc9ef6 Deployed Oct 30, 2026 by railway-app[bot]
rivet-frontend / agentos-pr-1968 — 3ddc9ef6 Deployed Oct 30, 2026 by railway-app[bot]
rivet-frontend / engine-ee-pr-1497 — 3ddc9ef6 Deployed Oct 30, 2026 by railway-app[bot]
rivet-frontend / agentos-pr-1947 — 3ddc9ef6 Deployed Oct 30, 2026 by railway-app[bot]
rivet-frontend / agentos-pr-1935 — 3ddc9ef6 Deployed Oct 30, 2026 by railway-app[bot]
rivet-frontend / agentos-pr-1985 — 3ddc9ef6 Deployed Oct 30, 2026 by railway-app[bot]
rivet-frontend / agentos-pr-1913 — 3ddc9ef6 Deployed Oct 30, 2026 by railway-app[bot]
rivet-frontend / agentos-pr-1905 — 3ddc9ef6 Deployed Oct 30, 2026 by railway-app[bot]
rivet-frontend / agentos-pr-1966 — 3ddc9ef6 Deployed Oct 30, 2026 by railway-app[bot]
rivet-frontend / engine-ee-pr-1354 — 3ddc9ef6 Deployed Oct 30, 2026 by railway-app[bot]
rivet-frontend / engine-ee-pr-1336 — 3ddc9ef6 Deployed Oct 30, 2026 by railway-app[bot]
rivet-frontend / engine-ee-pr-1347 — 3ddc9ef6 Deployed Oct 30, 2026 by railway-app[bot]
rivet-frontend / engine-ee-pr-1483 — 3ddc9ef6 Deployed Oct 30, 2026 by railway-app[bot]
rivet-frontend / engine-ee-pr-1430 — 3ddc9ef6 Deployed Oct 30, 2026 by railway-app[bot]
rivet-frontend / engine-ee-pr-1337 — 3ddc9ef6 Deployed Oct 30, 2026 by railway-app[bot]
rivet-frontend / dynamic-apps-pr-295 — 3ddc9ef6 Deployed Oct 30, 2026 by railway-app[bot]
rivet-frontend / agentos-pr-1906 — 3ddc9ef6 Deployed Oct 30, 2026 by railway-app[bot]
rivet-frontend / engine-ee-pr-1346 — 3ddc9ef6 Deployed Oct 30, 2026 by railway-app[bot]
rivet-frontend / engine-ee-pr-1470 — 3ddc9ef6 Deployed Oct 30, 2026 by railway-app[bot]
rivet-frontend / agentos-pr-2040 — 3ddc9ef6 Deployed Oct 30, 2026 by railway-app[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants