Complete ranked Rumble client execution - #7
Merged
Conversation
Selection checked distinctness by team identity only, so two teams sharing a member could both be picked and the battle would boot the same bot on both sides, making result attribution meaningless. Selection now tracks booked member identities, skips colliding candidates, drops an advice anchor whose pair overlaps, and fails loudly when the battle cannot be filled. Team-ness was hardcoded as a TWIN_DUEL comparison in three places with a magic divisor. GameType carries teamSize, the client-side twin of rumble-data's TEAM_SIZE, and the required entry count, catalog filter, error wording, and parser eligibility check all derive from it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hag2ofqnbadWJqvnboJU7s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
teamMembersmetadata across the Rumble catalog boundaryVerification
.\gradlew.bat --no-configuration-cache "-PtankRoyaleSource=../tank-royale" clean buildPart of robocode-dev/tank-royale#247. Related drafts: robocode-dev/rumble-bots#3 and robocode-dev/rumble-data#7.