Repository navigation
Conversation
 [Low impact] The PR appears safe to merge; the lockfile mismatch is fixed. Reviews (3) · Last reviewed commit: "update pnpm-lock.yaml hopefully correctl..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
sata04
added a commit
to sata04/AAT-Web
that referenced
this pull request
Oct 29, 2026
Maintain a version-scoped source patch for both published node-resolve entrypoints, using the fixed-defaults clone proposed in rollup/plugins#2036. That proposal is not an upstream release. Preserve the package version and official tarball integrity while recording pnpm's separate patch hash. Remove only the now-unused deepmerge dependency edge. Keep defaults frozen and independent across entrypoints, verify real Rollup resolution, and exercise the generated service worker with offline CSV analysis. No advisory exceptions or release-age policy changes are included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
node-resolveThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
As a result of the bogus advisory GHSA-gcqx-w48m-w2h4,
npm auditnow reports "2 low security vulnerabilities" due to thedeepmergedependency used by thenode-resolveplugin. The upstream maintainer has stated they will not be releasing a fix, as there is no actual vulnerability. However, since the only use ofdeepmergebynode-resolveis a single invocation which can be easily handled manually, my suggested solution, as implemented in this PR, is to take the opportunity to reduce the plugin's dependency count.