Skip to content

Graph changes should reach all interested nodes - #3422

Open
Timple wants to merge 2 commits into
ros2:rollingfrom
nobleo:fix/graph-listener-shared-guard-condition
Open

Timple wants to merge 2 commits into
ros2:rollingfrom
nobleo:fix/graph-listener-shared-guard-condition

Conversation

@Timple

@Timple Timple commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Description

Having to ros2 bag processes in a single composable node didn't work. As they subscribe to graph changes.

Is this user-facing behavior change?

If/when fixed, all nodes get the subscribed info

Did you use Generative AI?

Opus 5.5 helped.

Additional Information

Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl>
@Timple
Timple force-pushed the fix/graph-listener-shared-guard-condition branch from 4cb66b4 to b04673d Compare November 18, 2026 16:23
Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl>
@github-actions

Copy link
Copy Markdown

ABI Compliance Check

✅ Verdict: compatible

Library Verdict Summary
libcomponent_manager.so ✅ compatible No ABI changes detected.
librclcpp.so ✅ compatible No ABI changes detected.
librclcpp_action.so ✅ compatible No ABI changes detected.
librclcpp_lifecycle.so ✅ compatible No ABI changes detected.
✅ libcomponent_manager.so — full abidiff report

Compared:

  • Base: lib-base/libcomponent_manager.so
  • Head: lib-pr/libcomponent_manager.so @ 0019820
(empty report — no differences printed by abidiff)
✅ librclcpp.so — full abidiff report

Compared:

  • Base: lib-base/librclcpp.so
  • Head: lib-pr/librclcpp.so @ 0019820
Functions changes summary: 0 Removed (2 filtered out), 0 Changed, 0 Added (12 filtered out) functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable


✅ librclcpp_action.so — full abidiff report

Compared:

  • Base: lib-base/librclcpp_action.so
  • Head: lib-pr/librclcpp_action.so @ 0019820
(empty report — no differences printed by abidiff)
✅ librclcpp_lifecycle.so — full abidiff report

Compared:

  • Base: lib-base/librclcpp_lifecycle.so
  • Head: lib-pr/librclcpp_lifecycle.so @ 0019820
(empty report — no differences printed by abidiff)

Updated for commit 0019820 · check run · suppressions: /home/runner/work/_temp/ros2-abi-suppressions.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant