Repository navigation
Add traits for regular and lifecycle nodes - #3423
Open
ammaarrahmed wants to merge 1 commit into
Open
ammaarrahmed wants to merge 1 commit into
ammaarrahmed wants to merge 1 commit into
Conversation
Signed-off-by: Ammaar Ahmed <ammaarlatif53@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
rclcpp::is_nodeandrclcpp::is_lifecycle_node, along with their_vforms. Nowis_nodematchesrclcpp::Nodeand its subclasses andis_lifecycle_nodematchesrclcpp_lifecycle::LifecycleNodeand also its subclasses.Fixes #2875
Is this user-facing behavior change?
Yes, now users can include
rclcpp/node_traits.hppto check a node’s class family at compile time.Did you use Generative AI?
Yes, Gpt 6.1 Sol to write tests and help me with review and documentation
Additional Information
Verified locally on Ubuntu 26.
test_lifecycle_nodeand 2 intest_interface_traits