feat: use go-spiffe SDK directly instead of spiffe-helper sidecar - #522
Open
Alan-Cha wants to merge 1 commit into
Open
feat: use go-spiffe SDK directly instead of spiffe-helper sidecar#522Alan-Cha wants to merge 1 commit into
Alan-Cha wants to merge 1 commit into
Conversation
Remove spiffe-helper sidecar from operator pod and use go-spiffe SDK directly to fetch JWT-SVIDs from the SPIRE Workload API. Changes: - operator/cmd/main.go: Remove --jwt-svid-path flag, pass SpiffeSocket instead of JWTSVIDPath to controller - operator/internal/controller/clientregistration_controller.go: Replace JWTSVIDPath field with SpiffeSocket, add fetchJWTSVID() helper that uses workloadapi.Client.FetchJWTSVID() to get JWT-SVID - charts/operator/templates/manager/manager.yaml: Remove spiffe-helper sidecar container, jwt-svid volume, and --jwt-svid-path CLI arg - charts/operator/templates/manager/configmap-spiffe-helper.yaml: Delete (no longer needed) This matches the architecture already used by authbridge-proxy and eliminates the need for maintaining a separate spiffe-helper sidecar. Closes: #478 Signed-off-by: Alan Cha <Alan.cha1@ibm.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove spiffe-helper sidecar from operator pod and use go-spiffe SDK directly to fetch JWT-SVIDs from the SPIRE Workload API.
Changes
--jwt-svid-pathflag, pass SpiffeSocket to controller--jwt-svid-pathCLI argMotivation
This matches the architecture already used by authbridge-proxy and eliminates the need for maintaining a separate spiffe-helper sidecar. The go-spiffe SDK provides direct Workload API access, making the file-based JWT-SVID exchange unnecessary.
Testing
Closes
Replaces #478 with a clean implementation.
Assisted-By: Claude Code