Repository navigation
test(google-analytics): make canonical URL mode explicit - #43
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eco-CI source
Fix
Explicitly set
route.cleanUrls: falsein the GA example and correct the test comment. This preserves its existing canonical/index.htmlURL and page-path assertions across Rspress defaults. No assertions, plugin runtime, dependencies, or lockfiles change.Validation
On macOS, Node 24.20.0 / pnpm 11.15.0:
pnpm install --frozen-lockfile— passed, including package builds.pnpm e2e packages/rspress-plugin-google-analytics/index.spec.ts— 2/2 passed on pinned dependencies, before and after the fix.e594d85fusingpnpm install --frozen-lockfile --ignore-scriptsandpnpm build; packed core/shared withpnpm --filter @rspress/core pack --out <core.tgz>/pnpm --filter @rspress/shared pack --out <shared.tgz>and temporarily installed file overrides usingpnpm install --no-frozen-lockfile.DEBUG=rsbuild pnpm e2e packages/rspress-plugin-google-analytics/index.spec.ts— reproduced 1 URL failure before; 2/2 passed after the fix with those exact upstream artifacts.pnpm lint— no lint/type/format errors on both dependency combinations.pnpm test— 13/13 passed on both combinations, no snapshots updated.git diff --check— passed. Temporary dependency/lockfile changes restored before commit.Not run: full Linux ecosystem suite, full plugin browser matrix, and docs builds after the change. The focused tests execute real Chromium and retain all GA assertions.