fix(create-rstack): drop node types from lib template src

[elecmonkey]

With node in types, setTimeout in src is typed NodeJS.Timeout and leaks into the published .d.ts, forcing consumers to install @types/node; web app and component lib's src is browser code and needs nothing from it, so node stays only in the tests config.

[cloudflare-workers-and-pages]

Deploying rstack-cli with    Cloudflare Pages

Latest commit:	9f710e9
Status:	✅  Deploy successful!
Preview URL:	https://c8801506.rstack-cli.pages.dev
Branch Preview URL:	https://lib-src-drop-node-types.rstack-cli.pages.dev

View logs

[chenjiahan]

Node types were added intentionally.

They allow app code to use process.env.NODE_ENV and process.env.PUBLIC_*, which Rsbuild replaces at build time. It also support process.env.* or Node globals or APIs in rstack.config.*.

[elecmonkey]

Node types were added intentionally.

They allow app code to use process.env.NODE_ENV and process.env.PUBLIC_*, which Rsbuild replaces at build time. It also support process.env.* or Node globals or APIs in rstack.config.*.

1. The process.env could comes from Rspack. rstack/types references @rsbuild/core/types, which references @rspack/core/module, and that file declares:

namespace Rspack { interface Process { env: { [key: string]: any } } }
declare var process: NodeJS.Process;

With types: ["rstack/types"] and no node, process.env.NODE_ENV, process.env.PUBLIC_* and import.meta.env.* all still type-check.

2. For app templates, I agree with you keeping node is the better default.

3. For library templates it is not. Libraries emit .d.ts, and that is where @types/node leaks: setTimeout in src is typed NodeJS.Timeout instead of number. Rslib also does not deal any process.env.*: https://v1.rslib.rs/guide/advanced/env-vars#default-environment-variables.