Clarify ThreadPoolExecutor#kill documentation - #1111
Open
oiahoon wants to merge 1 commit into
Open
Conversation
eregon
approved these changes
Aug 19, 2026
eregon
left a comment
Member
There was a problem hiding this comment.
Looks good, one change needed though
Comment on lines
+3
to
+6
| concurrent-ruby: | ||
|
|
||
| * (#1072) Clarify that executor `#kill` may interrupt in-progress tasks. | ||
|
|
Member
There was a problem hiding this comment.
In recent releases we just link to GitHub releases to avoid duplication and extra work, could you therefore undo this change?
Member
|
Since this is |
oiahoon
force-pushed
the
docs/clarify-executor-kill
branch
from
August 20, 2026 04:10
8d8ee9c to
66b5cab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#killmay interrupt in-progress tasksCloses #1072
Verification
bundle exec rspec spec/concurrent/executor/fixed_thread_pool_spec.rb spec/concurrent/executor/simple_executor_service_spec.rb(110 examples, 0 failures)FixedThreadPool#killruntime checkBUNDLE_WITH=documentation bundle exec rake yard:masterbundle exec rake(2,795/2,796 examples passed; the timing-sensitive channel integration example that failed once passed on focused rerun)git diff --check