Include receiver and complete options in the instance cache key - #369
Open
OskarEichler wants to merge 1 commit into
Open
Include receiver and complete options in the instance cache key#369OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Key cached CSV objects by their receiver class, input identity, and full option hash. This also distinguishes explicitly supplied nil values from omitted options.
Reproduction
On the same string, calls with
encoding: "UTF-8"andencoding: "ISO-8859-1"incorrectly return one object. CallingCSV.instancebeforeCSV::TSV.instancereturns a CSV object for the TSV call. Unknown options can also bypass validation on a cache hit.Verification
10 focused checks: six failures on the release, zero with the patch, covering encodings, subclass separation, option order, explicit nil, unknown options, cache reuse and block returns.
This isolated patch passes the unchanged upstream suite in both normal and
CSV_PARSER_SCANNER_TEST=yesmodes: 527 tests / 4,050 assertions in each mode, zero failures/errors. Commands use Ruby 4.0.6 through rbenv (bundle exec ruby run-test.rb). Syntax andgit diff --checkpass. The combined release-based consumer branch also passes gem build andrake warning:error rdoc.No tests were added or changed, per the requesting project's explicit no-new-tests policy. Focused checks and measurements live outside this repository. The upstream no-RuboCop policy is respected. Verification was local on macOS/Ruby 4.0.6; the supported OS/Ruby matrix was not run locally. Current main and installed 3.3.6 share base commit
0873ab362d996f12796c3c3e8998b5be657a9b12; no unrelated changes are included.Breaking changes and limitations
Calls with different receiver/options now get different objects. Code depending on accidental cache collisions will observe corrected identity behavior. Cache lifetime and the documented lack of Ractor safety are unchanged.