Repository navigation
Add tests and CI, and remove rubyci-screenshot - #79
Merged
Merged
Conversation
It has not succeeded once in the last year, and the rubyzip 3.4.0 bump left no Ruby that can run it, because rubyzip now requires Ruby 3.0 while selenium-webdriver 3.142.6 does not work on Ruby 3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ruby 2.7 is EOL. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dependency bumps from dependabot had nothing to check them. The fixtures are records trimmed from rubyci.org's servers.json and reports.json. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot bumps had no CI to check them, and the rubyzip 3.4.0 bump in #76 broke
rubyci-screenshot. rubyzip 3.4.0 requires Ruby 3.0, while the workflow ran on Ruby 2.7 and selenium-webdriver 3.142.6 does not work on Ruby 3.The screenshot had not succeeded once in the last year, so I removed it instead of fixing it. This also drops selenium-webdriver and rubyzip from the
Gemfile.I added tests that run the report extraction and timestamp filtering of
rubyci-alerts.rbagainst fixtures trimmed from rubyci.org'sservers.jsonandreports.json, and atestworkflow that runs them on push and pull requests.rubyci-alertsnow runs on Ruby 4.0, the same version as the tests, since Ruby 2.7 is EOL.Generated with Claude Code