Remove enable_packs feature flag (builds on #5642) - #5685
Merged
Conversation
The enable_packs flag removal deleted the only test for PicklistsPdf#data_no_units, but that method is still live code -- it runs whenever a request's line items have no custom units. Restore the test without the flag context. Also fix Partners::ItemRequest#quantity_with_units specs, where the "when there is no request unit" context was accidentally left nested inside "when there is a request unit" during the unwrap. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RghnRBKSCZ2ydQnq9ZBxop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5251
Description
This builds directly on #5642 by @stefannibrasil (all of that work is included here, with credit — thank you!). That PR is a clean, surgical removal of the
enable_packsflag: everyFlipper.enabled?(:enable_packs)check is unwrapped keeping the enabled path, flag-off-only tests are deleted, and seeds/docs are updated. No references to the flag remain anywhere in the repo after this.This branch adds one commit on top fixing two small spec issues from the unwrap:
PicklistsPdf#data_no_units. Its only test was deleted because it lived in a "When packs are not enabled" context, but the method is still live code — it runs whenever a request's line items have no custom units, which is independent of the (removed) flag. The test is restored without the flag context.Partners::ItemRequest#quantity_with_unitsspecs, where "when there is no request unit" was accidentally left nested inside "when there is a request unit".Type of change
How Has This Been Tested?
bundle exec rspec spec/models/partners/item_request_spec.rb spec/pdfs/picklists_pdf_spec.rb— 21 examples, 0 failures. Rubocop clean on the touched files.🤖 Generated with Claude Code
https://claude.ai/code/session_01RghnRBKSCZ2ydQnq9ZBxop