This repository was archived by the owner on Nov 10, 2026. It is now read-only.
Repository navigation
ci: create releases with the built-in token instead of the release app - #401
Merged
Merged
Conversation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Release job fails at token creation:
The permissions requested are not granted to this installation(422). Since #399, the token step asks the release apprunpod-release-pleaseforcontents,issues,pull-requestsandworkflows. The app only hascontents: write,pull_requests: writeandmetadata: read(gh api apps/runpod-release-please-bot). Granting more needs an org owner.This drops the app token and gives release-please the built-in
GITHUB_TOKEN, as runpod-python does. The workflow already grantscontents,pull-requestsandissueswrite.Why this works for 1.21.1
github-actions[bot]created runpod-python v1.9.0 to v1.12.0 with the built-in token, and those release ranges changed.github/workflows/. So the token can tag releases like this one.release_created, and no flash workflow triggers on release events. The built-in token not triggering other workflows doesn't matter here.Trade-off
#97 moved to the app because the built-in token stopped working, most likely because flash disallows Actions from creating PRs. If that setting is still off, release-please can't open the next release PR with this token.
runpod-flashstopped getting fixes on 2026-10-29, so 1.21.1 is expected to be the last release.After merge
The push to main runs Release. It should create v1.21.1 and publish to PyPI from the GitHub-hosted runner (#400). Merge runpod-workers/flash#112 first (worker 1.6.1), because 1.21.1 includes #390.