Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
REST and Apps clients still treat unfollowed 3xx redirects as success, allowing deletions or uploads to be reported complete without reaching their destination.
1 open issue
What changed in this PR
This PR centralizes HTTP routing and connection management across the SDK and CLI, separates authentication from Apps, and consolidates both CLI entry points under runpod.cli.
Changes:
- Adds escaped route templates and scoped HTTP/REST clients with connection reuse and response cleanup.
- Migrates endpoint, Apps, GraphQL, and authentication requests to shared infrastructure.
- Updates CLI imports, compatibility aliases, tests, and contributor guidance.
| File | Description |
|---|---|
| tests/test_shared/test_auth.py | Updates credential mock location. |
| tests/test_profile.py | Uses shared credential storage. |
| tests/test_network_volume_transfer.py | Updates CLI and authentication imports. |
| tests/test_endpoint/test_transport.py | Adds routing and response-lifetime coverage. |
| tests/test_endpoint/test_failed_jobs.py | Adapts async response mocks. |
| tests/test_endpoint/test_asyncio_runner.py | Adapts mocks to shared requests. |
| tests/test_cli/test_volume_command.py | Updates volume CLI imports and patches. |
| tests/test_cli/test_update_command.py | Uses consolidated update command. |
| tests/test_cli/test_stream_encoding.py | Updates CLI subprocess imports. |
| tests/test_cli/test_project_commands.py | Updates project-command imports. |
| tests/test_cli/test_pod_command.py | Updates CLI and transport mocks. |
| tests/test_cli/test_management_commands.py | Updates management and login mocks. |
| tests/test_cli/test_init_command.py | Uses consolidated CLI entry point. |
| tests/test_cli/test_endpoint_command.py | Updates endpoint CLI imports. |
| tests/test_cli/test_deploy_command.py | Uses consolidated deploy command. |
| tests/test_cli/test_console.py | Uses relocated console module. |
| tests/test_cli/test_compute.py | Uses relocated compute module. |
| tests/test_cli/test_cli_output.py | Updates output helper imports. |
| tests/test_cli/test_cli_options.py | Updates option helper imports. |
| tests/test_cli/test_cli_logs.py | Uses relocated log commands. |
| tests/test_cli/test_cli_groups/test_ssh_dispatch.py | Uses consolidated SSH entry point. |
| tests/test_cli/test_cli_api.py | Uses relocated CLI API helpers. |
| tests/test_cli/test_catalog_command.py | Updates catalog imports and mocks. |
| tests/test_cli/test_agent_login.py | Updates shared login and credential references. |
| tests/test_auth/test_package.py | Tests authentication package boundaries and compatibility. |
| tests/test_auth/test_login.py | Uses relocated browser login. |
| tests/test_auth/test_credentials.py | Targets shared credential storage. |
| tests/test_auth/test_api.py | Adds dedicated authentication client tests. |
| tests/test_auth/test_agent_login.py | Adapts agent-login transport tests. |
| tests/test_auth/__init__.py | Defines authentication test package. |
| tests/test_apps/test_user_agent.py | Updates transport attribution tests. |
| tests/test_apps/test_transport_parity.py | Mocks shared HTTP clients. |
| tests/test_apps/test_tasks.py | Adapts task transport mocks. |
| tests/test_apps/test_targets.py | Tests shared load-balancer URL helper. |
| tests/test_apps/test_retry.py | Tests session reuse across retries. |
| tests/test_apps/test_logs.py | Adapts log streaming mocks. |
| tests/test_apps/test_http_transport.py | Adds Apps routing and credential-boundary coverage. |
| tests/test_apps/test_http_errors.py | Uses host API environment configuration. |
| tests/test_apps/test_entrypoint_execution.py | Updates embedded CLI import. |
| tests/test_apps/test_app.py | Updates catalog transport mocks. |
| tests/test_apps/test_api_client.py | Moves authentication coverage to its own suite. |
| tests/test_api/test_rate_limit.py | Updates session-level request mock. |
| tests/test_api/test_http.py | Tests routes, ownership, pooling, and credentials. |
| setup.py | Points both commands to shared CLI. |
| runpod/rp_cli/__init__.py | Removes old package docstring. |
| runpod/network_volume_transfer.py | Loads credentials from authentication package. |
| runpod/http_client.py | Updates credential import. |
| runpod/endpoint/runner.py | Uses shared transport and adds pool cleanup. |
| runpod/endpoint/asyncio/asyncio_runner.py | Uses shared routes with borrowed sessions. |
| runpod/cli/volume.py | Updates CLI and credential dependencies. |
| runpod/cli/update.py | Houses CLI update functionality. |
| runpod/cli/pod.py | Uses consolidated CLI helpers. |
| runpod/cli/output.py | Uses relocated console renderer. |
| runpod/cli/options.py | Uses consolidated API and compute helpers. |
| runpod/cli/main.py | Integrates shared CLI and authentication modules. |
| runpod/cli/logs.py | Updates shared CLI dependencies. |
| runpod/cli/groups/config/__init__.py | Aliases legacy credential imports. |
| runpod/cli/endpoint.py | Uses consolidated endpoint CLI helpers. |
| runpod/cli/endpoint_config.py | Updates configuration helper imports. |
| runpod/cli/console.py | Houses shared CLI rendering. |
| runpod/cli/compute.py | Houses catalog resolution helpers. |
| runpod/cli/catalog.py | Uses consolidated catalog dependencies. |
| runpod/cli/api.py | Updates compute error import. |
| runpod/auth/login.py | Separates login flows and adopts shared transport. |
| runpod/auth/credentials.py | Updates credential module documentation. |
| runpod/auth/api.py | Adds dedicated authentication API client. |
| runpod/auth/__init__.py | Centralizes API-key selection. |
| runpod/apps/utils/network.py | Uses shared HTTP and endpoint helpers. |
| runpod/apps/tasks.py | Migrates task requests to scoped clients. |
| runpod/apps/targets.py | Shares routing and retry connection pools. |
| runpod/apps/logs.py | Uses shared routes and configurable log service. |
| runpod/apps/api.py | Separates authentication and reuses upload sessions. |
| runpod/api/routes.py | Adds escaped routes and service URL helpers. |
| runpod/api/rest.py | Adds reusable REST clients with quota handling. |
| runpod/api/queries/apps.py | Removes relocated authentication query. |
| runpod/api/mutations/apps.py | Removes relocated authentication mutation. |
| runpod/api/http.py | Adds shared synchronous and asynchronous transports. |
| runpod/api/graphql.py | Uses shared transports and key resolution. |
| runpod/_hosts.py | Centralizes additional service configuration. |
| runpod/__init__.py | Routes credential exports through authentication package. |
| pyproject.toml | Updates both CLI entry points. |
| CONTRIBUTING.md | Documents transport and package conventions. |
Review effort: Balanced
| self.session._retry_connection = False | ||
| if not isinstance(timeout, aiohttp.ClientTimeout): | ||
| timeout = aiohttp.ClientTimeout(total=timeout) | ||
| kwargs.setdefault("allow_redirects", False) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adding an SDK or CLI request involves several URL builders, HTTP session wrappers, and credential locations. Shared route templates and scoped clients give these requests consistent parameter escaping, service configuration, and response cleanup. Related REST requests can reuse one connection pool:
Moved out auth stuff into a more top level auth module. and now both
rpandrunpoduse the same CLI package