Skip to content

Rename Sink::SinkError to Sink::Error - #1708

Merged
seanmonstar merged 1 commit into
rust-lang:masterfrom
seanmonstar:sink-error
Jul 3, 2019
Merged

Rename Sink::SinkError to Sink::Error#1708
seanmonstar merged 1 commit into
rust-lang:masterfrom
seanmonstar:sink-error

Conversation

@seanmonstar

Copy link
Copy Markdown
Contributor

Closes #1707

@cramertj

cramertj commented Jul 3, 2019

Copy link
Copy Markdown
Member

r=me with travis passing.

@seanmonstar

Copy link
Copy Markdown
Contributor Author

Hrm, I'm guessing this failure is due to improvements in nightly?

---- join_size stdout ----
thread 'join_size' panicked at 'assertion failed: `(left == right)`
  left: `32`,
 right: `44`', futures/tests/async_await_macros.rs:178:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

@taiki-e

taiki-e commented Jul 3, 2019

Copy link
Copy Markdown
Member

@seanmonstar Yes, that is because the generator size has been improved. (rust-lang/rust#61922).

@cramertj

cramertj commented Jul 3, 2019

Copy link
Copy Markdown
Member

Yeah, I've got a PR updating those.

@cramertj

cramertj commented Jul 3, 2019

Copy link
Copy Markdown
Member

#1711

@cramertj

cramertj commented Jul 3, 2019

Copy link
Copy Markdown
Member

@seanmonstar Would you mind rebasing just so I can see a clean CI run on this before merging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename Sink::SinkError to just Sink::Error

3 participants