fix: add missing definitions for io-sock QNX - #5469
Open
lambinoo wants to merge 1 commit into
Open
Conversation
lambinoo
force-pushed
the
fix-missing-bits-qnx8
branch
from
September 4, 2026 11:09
fbbe72e to
b32f2a1
Compare
lambinoo
changed the title
lambinoo
force-pushed
the
fix-missing-bits-qnx8
branch
from
September 4, 2026 11:55
b32f2a1 to
543e03a
Compare
tgross35
reviewed
Sep 4, 2026
Member
There was a problem hiding this comment.
Looks reasonable enough to me but the target maintainers should review/test. Cc @flba-eb @gh-tr @jonathanpallant @japaric
@rustbot label +S-waiting-on-maintainer
Comment on lines
+58
to
+63
| // https://github.com/freebsd/freebsd-src/blob/f0cf0b8266eef39b13917f7bed808daf6d6a2d3e/sys/netinet/in.h#L549 | ||
| pub struct ip_mreqn { | ||
| pub imr_multiaddr: in_addr, | ||
| pub imr_address: in_addr, | ||
| pub imr_ifindex: c_int, | ||
| } |
Member
There was a problem hiding this comment.
Please put these links into the commit message, rather than in comments
Author
There was a problem hiding this comment.
Updated! Also fixed the the in_addr fields to crate::in_addr since that's what the rest of the file is using
This comment has been minimized.
This comment has been minimized.
Collaborator
|
lambinoo
force-pushed
the
fix-missing-bits-qnx8
branch
from
September 6, 2026 14:21
b539bb3 to
54be82a
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
lambinoo
force-pushed
the
fix-missing-bits-qnx8
branch
from
September 6, 2026 14:24
54be82a to
33e91af
Compare
For reference, the QNX io-sock networking stack is based on FreeBSD 13.2 release: https://www.qnx.com/developers/docs/relnotes8.0/com.qnx.doc.release_notes/topic/sdp8_rn.html See `What's new in QNX SDP? > Networking` for details Following under are the references to the FreeBSD headers: - `ip_mreqn`: https://github.com/freebsd/freebsd-src/blob/f0cf0b8266eef39b13917f7bed808daf6d6a2d3e/sys/netinet/in.h#L549 - `ip_mreq_source`: https://github.com/freebsd/freebsd-src/blob/f0cf0b8266eef39b13917f7bed808daf6d6a2d3e/sys/netinet/in.h#L558 - `TCP_KEEPIDLE`: https://github.com/freebsd/freebsd-src/blob/f0cf0b8266eef39b13917f7bed808daf6d6a2d3e/sys/netinet/tcp.h#L208 - `TCP_KEEPINTVL`: https://github.com/freebsd/freebsd-src/blob/f0cf0b8266eef39b13917f7bed808daf6d6a2d3e/sys/netinet/tcp.h#L209 - `TCP_KEEPCNT`: https://github.com/freebsd/freebsd-src/blob/f0cf0b8266eef39b13917f7bed808daf6d6a2d3e/sys/netinet/tcp.h#L210 - `IP_RECVTOS`: https://github.com/freebsd/freebsd-src/blob/f0cf0b8266eef39b13917f7bed808daf6d6a2d3e/sys/netinet/in.h#L487 - `IP_ADD_SOURCE_MEMBERSHIP`: https://github.com/freebsd/freebsd-src/blob/f0cf0b8266eef39b13917f7bed808daf6d6a2d3e/sys/netinet/in.h#L490 - `IP_DROP_SOURCE_MEMBERSHIP`: https://github.com/freebsd/freebsd-src/blob/f0cf0b8266eef39b13917f7bed808daf6d6a2d3esys/netinet/in.h#L491
lambinoo
force-pushed
the
fix-missing-bits-qnx8
branch
from
September 6, 2026 14:26
33e91af to
53c3ebe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm currently working on getting socket2 to compile for QNX8 networking stack. This PR adds some missing network related structs and constants.