build: Assert that cfg makes sense - #5491
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Adjust configuration so that we are not e.g. setting `freebsd12` on non-FreeBSD targets, and add assertions that similar configuration setups make sense. This also means we aren't spending the (small) time to invoke version-fetching commands on targets where they won't even be used.
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
dybucc
reviewed
Sep 6, 2026
| /// Corresponds to `_TIME_BITS=64` in glibc. Also used in x86 Windows with | ||
| /// GNU to expose a 64-bit `time_t`. | ||
| /// Corresponds to `_TIME_BITS=64` in glibc. Also used in x86 Windows with GNU | ||
| /// to expose a 64-bit `time_t`. Implies 32-bit GNU target and 64-bit `off_t`. |
Contributor
There was a problem hiding this comment.
I don't think it's right to say that it implies 64-bit off_t. Windows
has no issues with off_t; It is time_t that is made 64-bits when
this cfg is issued.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust configuration so that we are not e.g. setting
freebsd12onnon-FreeBSD targets, and add assertions that similar configuration
setups make sense.