Skip to content

Prevent should-fail to be used in rustdoc-ui testsuite - #162446

Open
GuillaumeGomez wants to merge 1 commit into
rust-lang:mainfrom
GuillaumeGomez:rustdoc-ui-should-fail
Open

Prevent should-fail to be used in rustdoc-ui testsuite#162446
GuillaumeGomez wants to merge 1 commit into
rust-lang:mainfrom
GuillaumeGomez:rustdoc-ui-should-fail

Conversation

@GuillaumeGomez

Copy link
Copy Markdown
Member

Follow-up of #162030 and discussion with @fmease.

There is no reason to use should-fail for rustdoc-ui (or rustdoc-html) testsuite, so let's prevent it.

r? @fmease

@rustbot

rustbot commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in src/tools/compiletest

cc @jieyouxu

compiletest directives have been modified. Please add or update docs for the
new or modified directive in src/doc/rustc-dev-guide/.

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants