Skip to content

yoink has_primitive_or_keyword_or_attribute_docs - #162525

Open
mejrs wants to merge 1 commit into
rust-lang:mainfrom
mejrs:has_primitive_or_keyword_or_attribute_docs
Open

yoink has_primitive_or_keyword_or_attribute_docs#162525
mejrs wants to merge 1 commit into
rust-lang:mainfrom
mejrs:has_primitive_or_keyword_or_attribute_docs

Conversation

@mejrs

@mejrs mejrs commented Sep 9, 2026

Copy link
Copy Markdown
Member

It looks like this was added as an optimization in #107932, but it should return false the vast majority of the time.

@rustbot

rustbot commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_attr_ir

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 9, 2026
@rustbot

rustbot commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

r? @ShoyuVanilla

rustbot has assigned @ShoyuVanilla.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 76 candidates
  • Random selection from 21 candidates

@mejrs

mejrs commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 9, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Sep 9, 2026
…ocs, r=<try>

yoink has_primitive_or_keyword_or_attribute_docs
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job test-aarch64-gnu-llvm-21-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- [rustdoc-html] tests/rustdoc-html/doc-on-keyword.rs stdout ----
------python3 stdout------------------------------

------python3 stderr------------------------------
8: has check failed
 `XPATH PATTERN` did not match
 //@ has - '//a[@href="{{channel}}/core/marker/trait.Send.html"]' 'Send'
9: has check failed
 `XPATH PATTERN` did not match
 //@ has - '//a[@href="{{channel}}/core/marker/trait.Sync.html"]' 'Sync'

Encountered 2 errors

------------------------------------------

error: htmldocck failed!
status: exit status: 1
command: "/usr/bin/python3" "/checkout/src/etc/htmldocck.py" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/rustdoc-html/doc-on-keyword" "/checkout/tests/rustdoc-html/doc-on-keyword.rs"
stdout: none
--- stderr -------------------------------
8: has check failed
 `XPATH PATTERN` did not match
 //@ has - '//a[@href="{{channel}}/core/marker/trait.Send.html"]' 'Send'
9: has check failed
 `XPATH PATTERN` did not match
 //@ has - '//a[@href="{{channel}}/core/marker/trait.Sync.html"]' 'Sync'

Encountered 2 errors
------------------------------------------

---- [rustdoc-html] tests/rustdoc-html/doc-on-keyword.rs stdout end ----

@rust-bors

rust-bors Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 42ed66d (42ed66d10b17b5b55ac93ef0a4f40220698174bd)
Base parent: eca445e (eca445e5ae4a6679cc27d3a09106ce245e13a5a6)

@rust-timer

This comment has been minimized.

@mejrs

mejrs commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

(not entirely sure this change is correct actually, brb)

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (42ed66d): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.6%, secondary 3.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
1.2% [0.5%, 2.6%] 5
Regressions ❌
(secondary)
3.7% [3.7%, 3.7%] 1
Improvements ✅
(primary)
-0.8% [-1.2%, -0.5%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.6% [-1.2%, 2.6%] 7

Cycles

Results (primary -0.3%, secondary 6.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.6% [0.4%, 0.9%] 6
Regressions ❌
(secondary)
6.5% [6.5%, 6.5%] 1
Improvements ✅
(primary)
-0.9% [-2.3%, -0.4%] 9
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.3% [-2.3%, 0.9%] 15

Binary size

Results (primary 0.0%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.0% [0.0%, 0.1%] 44
Regressions ❌
(secondary)
0.1% [0.0%, 0.1%] 8
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.0% [0.0%, 0.1%] 44

Bootstrap: 481.923s -> 481.291s (-0.13%)
Artifact size: 403.28 MiB -> 403.36 MiB (0.02%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants