Skip to content

Revert "Use SIMD intrinsics for vector shifts" - #2217

Open
RalfJung wants to merge 3 commits into
rust-lang:mainfrom
RalfJung:vector-shift-codegen
Open

Revert "Use SIMD intrinsics for vector shifts"#2217
RalfJung wants to merge 3 commits into
rust-lang:mainfrom
RalfJung:vector-shift-codegen

Conversation

@RalfJung

@RalfJung RalfJung commented Sep 5, 2026

Copy link
Copy Markdown
Member

Reverts #1955 to fix rust-lang/rust#159831 and to fix rust-lang/rust#159801.
Cc @sayantn

No tests because the per-intrinsic codegen is actually fine, it's the combined codegen with other operations where things fall apart.

@rustbot

rustbot commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

r? @adamgemmell

rustbot has assigned @adamgemmell.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @Amanieu, @adamgemmell, @davidtwco, @folkertdev, @sayantn
  • @Amanieu, @adamgemmell, @davidtwco, @folkertdev, @sayantn expanded to Amanieu, adamgemmell, davidtwco, folkertdev, sayantn
  • Random selection from Amanieu, adamgemmell, davidtwco, folkertdev, sayantn

@RalfJung

RalfJung commented Sep 5, 2026

Copy link
Copy Markdown
Member Author

(CI seems to be generally broken, that's not from my PR.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Poor codegen for AVX2 variable shift intrinsics: _mm256_sllv_epi32 and _mm256_srlv_epi32 Suboptimal codegen for _mm512_sllv_epi16

3 participants