Skip to content

Revert "Reimplement _mm_mulhi_epi16, ... without LLVM intrinsics" - #2219

Open
RalfJung wants to merge 4 commits into
rust-lang:mainfrom
RalfJung:mulhi
Open

Revert "Reimplement _mm_mulhi_epi16, ... without LLVM intrinsics"#2219
RalfJung wants to merge 4 commits into
rust-lang:mainfrom
RalfJung:mulhi

Conversation

@RalfJung

@RalfJung RalfJung commented Sep 5, 2026

Copy link
Copy Markdown
Member

Reverts parts of #1477 to fix rust-lang/rust#159474.
Cc @eduardosm

@rustbot

rustbot commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

r? @sayantn

rustbot has assigned @sayantn.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @Amanieu, @adamgemmell, @davidtwco, @folkertdev, @sayantn
  • @Amanieu, @adamgemmell, @davidtwco, @folkertdev, @sayantn expanded to Amanieu, adamgemmell, davidtwco, folkertdev, sayantn
  • Random selection from Amanieu, adamgemmell, davidtwco, folkertdev, sayantn

@RalfJung RalfJung Sep 5, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW there are also _mm512 variants of this... those should then probably also use the LLVM intrinsic?

View changes since the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

std::arch::x86_64::_mm_mulhi_epu16(vector, _mm_set1_epi16(scalar)) generates slow emulated path instead of pmulhuw (regressed in rustc 1.75)

3 participants