Skip to content

docs(readme): state uv 0.13.0 pin, supported Python range and test command - #323

Merged
saagpatel merged 3 commits into
mainfrom
fix/clean-room-2026-11
Nov 18, 2026
Merged

saagpatel merged 3 commits into
mainfrom
fix/clean-room-2026-11

Conversation

@saagpatel

@saagpatel saagpatel commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

This came from a clean-room rebuild: a fresh clone, following the README only.

What broke on the cold attempt

make setup and make demo failed because the repo pins uv ==0.13.0 in pyproject.toml and the machine had uv 0.13.9. The README never stated the required uv version.

What changed (README only)

  • Prerequisites now give the supported Python range (3.12 to 3.14, not 3.15), the exact uv 0.13.0 requirement with commands to switch to it, and pnpm and Node.
  • The demo snippet uses uv sync --locked --extra config instead of an unused pip install.
  • The contributor section names make check as the test command and make check-python for Python tests only.

Final cold-attempt result

Still red, with this exact blocker: the required prerequisite uv ==0.13.0 is not installed (the machine has uv 0.13.9) and pyproject.toml pins an exact version. The documented fix path was not verified end to end for that reason. Owner options: relax the pin, or install uv 0.13.0 as the README now describes.

Follow-up cold attempt

Two more fix cycles ran after the PR opened. Cycle 2 documented a clone-local uv 0.13.0 (.uv-tool, gitignored) so the exact pin works without a global uv change; the pin itself is unchanged. That exposed a real failure: next build aborted on Next.js 16.4.3 because of a security advisory. Cycle 3 bumped next and eslint-config-next to 16.4.6 in web/ and refreshed the lockfile. The final cold attempt (fresh clone, README only) went green: make setup, then make check with ruff clean, 3763 Python tests passed, web tests and next build passing. The Next.js bump is a dependency change, so it deserves a reviewer's look.

@saagpatel
saagpatel marked this pull request as ready for review November 18, 2026 07:11
@saagpatel
saagpatel merged commit 3b26f6d into main Nov 18, 2026
7 checks passed
@saagpatel
saagpatel deleted the fix/clean-room-2026-11 branch November 18, 2026 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant