Repository navigation
docs(readme): state uv 0.13.0 pin, supported Python range and test command - #323
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came from a clean-room rebuild: a fresh clone, following the README only.
What broke on the cold attempt
make setupandmake demofailed because the repo pins uv ==0.13.0 inpyproject.tomland the machine had uv 0.13.9. The README never stated the required uv version.What changed (README only)
uv sync --locked --extra configinstead of an unused pip install.make checkas the test command andmake check-pythonfor Python tests only.Final cold-attempt result
Still red, with this exact blocker: the required prerequisite uv ==0.13.0 is not installed (the machine has uv 0.13.9) and
pyproject.tomlpins an exact version. The documented fix path was not verified end to end for that reason. Owner options: relax the pin, or install uv 0.13.0 as the README now describes.Follow-up cold attempt
Two more fix cycles ran after the PR opened. Cycle 2 documented a clone-local uv 0.13.0 (.uv-tool, gitignored) so the exact pin works without a global uv change; the pin itself is unchanged. That exposed a real failure: next build aborted on Next.js 16.4.3 because of a security advisory. Cycle 3 bumped next and eslint-config-next to 16.4.6 in web/ and refreshed the lockfile. The final cold attempt (fresh clone, README only) went green: make setup, then make check with ruff clean, 3763 Python tests passed, web tests and next build passing. The Next.js bump is a dependency change, so it deserves a reviewer's look.