Repository navigation
fix: 웹 알림 호환과 터미널 재생성 검사 보완 - #42
Merged
Merged
Conversation
Pre-merge checks:
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Title check |  |
This assessment has not completed. The check will be retried on the next pre-merge check run. | |
| Description check | |
This assessment has not completed. The check will be retried on the next pre-merge check run. |
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
웹 알림의 완료 콜백 타입이 Xcode 16.4에서 optional delegate 경고를 내므로, async WKUIDelegate 메서드로 같은 시트의 완료를 기다리도록 바꿉니다. SDK별 타입 분기를 제거하며 버튼·한국어 문구·배치는 유지합니다. 이전 SDK의 빌드에서 해당 경고가 없음을 확인했습니다.
16칸 터미널 검사에서 셸을 다시 연 직후 닫을 때 엔진 종료 대기가 두 번 관찰됐습니다. 새 셸의 실제 명령·독립 출력 줄·유휴 상태를 확인한 뒤 닫도록 fixture를 강화했습니다. 기존 세 번의 닫기·재생성과 칸 수·ID·환경·저장·복원 검사는 유지하며, 엔진의 즉시 종료 원인까지 해결했다고 주장하지 않습니다.
./scripts/check.sh의 릴리스 빌드·서명과 55개 검사 통과(20.692초). 실제 WKWebView의 알림·확인·입력 시트 응답과 열린 확인창을 칸과 함께 닫을 때의 취소 결과도 확인했습니다. 디자인 게이트 PASS. 셀프 리뷰이며 독립 승인으로 표시하지 않습니다. 진단과 검증 기록.