Repository navigation
Bring iOS level with recent Android ring fixes and features - #143
Open
saksham2001 wants to merge 20 commits into
Open
saksham2001 wants to merge 20 commits into
saksham2001 wants to merge 20 commits into
Conversation
… replies on their own thread
…mini 503s with backoff
…tired-model warnings and OpenRouter's real reasoning levels
…e current discharge
…ys already summed as buckets
…yte is not HRV in milliseconds
… near the turnover
…stead of the sample window
…be deleted for good
…over time the ring missed
… and draw them on the hypnogram
…d keeps a night whole inside it
…o a re-sync can't restore them
…tion and a full-window chart axis
…with delete, tombstoned against re-sync
…estimated on the card and detail screen
… seed lines to stay under SwiftLint's error limits
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings iOS level with what the Android app (foureight84/PulseLoopAndroid) has merged since its last iOS sync (Oct 14). Each change follows Android's behaviour, written as Swift in the existing iOS style; Android PR numbers are in brackets. Stacked on #142 (
feat/ring-clear-after-sync), so the diff here is only this work.Ring fixes
f04a76a) because it left real nights empty. It is not included here, so nights stored before this fix stay where they are.CRPSpotMeasurementends the measurement on that one result.Sleep
SleepRecordEdit;SleepStageBlock.recordStartAt;SleepStage.added.Vitals and Activity
MeasurementDeletion.YCBT rings and battery
Coach
Other
ActivityRecorderServicemoved out ofPulseServices.swiftunchanged, so that file stays under SwiftLint's 1000-line error limit.Data: three SwiftData additions (
SleepRecordEdit,MeasurementDeletion, plus new fields with defaults on existing models).DataArchivecarries all of them as optional fields, so older exports still import.Related issues
Ports Android PRs #62, #71, #80, #91, #92, #95, #108, #116, #117, #118, #119, #120, #122, #127, #129, #130, #133, #134 (foureight84/PulseLoopAndroid). Builds on #142.
Type of change
How was this tested?
PulseLoopTests): Android's test cases were ported where they exist.-seedDemo YES, no hardware): Vitals detail, the Activity day view and records, and the Sleep records card were checked in the simulator.Not checked yet:
Needs a real ring before merge:
Privacy & data
Screenshots / recordings
Not attached.
Checklist
docs/hardware/colmi.md,luckring.md,tk5.md,r10m.md).