Skip to content

Expand the common DKIM selector probe list - #12

Open
sage-s11 wants to merge 1 commit into
sanmaxdev:mainfrom
sage-s11:issue-7-expand-dkim-selectors
Open

Expand the common DKIM selector probe list#12
sage-s11 wants to merge 1 commit into
sanmaxdev:mainfrom
sage-s11:issue-7-expand-dkim-selectors

Conversation

@sage-s11

@sage-s11 sage-s11 commented Aug 29, 2026

Copy link
Copy Markdown

Probe additional stable, documented selectors used by major providers so DKIM presence is less often reported as undetected. Skip per-tenant dynamic selectors.

Summary

DKIM presence is probed from COMMON_DKIM_SELECTORS in src/sentineldeck/scanners/email_security.py. A miss is inconclusive, so a short list produces false "not detected" results for domains that only publish a well-known provider selector we were not checking.

This expands the list with static, publicly documented selectors used by major providers (Google Workspace, Microsoft 365, Mailchimp, Mandrill, SendGrid, Zoho, Proton Mail, Fastmail, Apple iCloud, Yahoo/AOL legacy, Zendesk, Brevo). Each entry has a short provider comment. Per-tenant / generated selectors are still omitted (Amazon SES tokens, Postmark dated selectors, HubSpot hs1-<portalId>, etc.).

Closes #7

Changes

  • Expand COMMON_DKIM_SELECTORS with documented static selectors and
    provider comments.
  • Add a unit test that the list is unique and includes the new
    documented names.

Checklist

  • ruff check . passes
  • pytest -q passes
  • New behaviour has tests (network calls mocked)
  • The change is passive-safe (no intrusive scanning)
  • README / CHANGELOG updated if user-facing

Probe additional stable, documented selectors used by major
providers so DKIM presence is less often reported as undetected.
Skip per-tenant dynamic selectors.
@sage-s11
sage-s11 requested a review from sanmaxdev as a code owner August 29, 2026 23:48

@sanmaxdev sanmaxdev left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the expanded selector set against issue #7 and the passive lookup path. The change stays scoped and preserves inconclusive handling for misses.

Passed:

  • ruff check .
  • mypy
  • pytest -q --cov=sentineldeck --cov-fail-under=75 (261 passed, 81.09% coverage)
  • bandit -r src -c pyproject.toml
  • git diff --check origin/main...HEAD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand the common DKIM selector probe list

2 participants