fix(#2097): scope QA notify workflow to default branch - #2098
Merged
Conversation
The QA notify template (notify-qa.yml, copied into every *-Contribution repo) triggered on push to ANY branch (no branches: filter). A push to a feature branch — e.g. the devtoberfest validation-tutorial bot's validation-tutorial/* branches — dispatched a QA rebuild for a slug that existed only on that branch. QA discovery reads the default branch, so the slug was a phantom and the rebuild hard-failed 'unknown slug in filter'. Bring the QA template to parity with the PROD template (docs/authors/tutorial-repo-dispatch.yml): - add branches: [master, main] (both, since Tutorials-Contribution defaults to master while the rest default to main) - add the strict slug-charset guard on the inferred slug Add a QA-template branch-trigger regression guard mirroring the PROD one. All 23 -Contribution repos currently ship the unfiltered template; propagate via scripts/install-notify-workflows.ts --only qa --execute after merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
QA content rebuild #2097 hard-failed with
unknown slug in filter: devtoberfest2026-abap-week1-validation.Root cause:
notify-qa.yml(the template copied into every*-Contributionrepo) triggers onpush: paths: ['tutorials/**']with nobranches:filter. The devtoberfest validation-tutorial bot pushed branchvalidation-tutorial/devtoberfest2026-abap-week1-validationtodeveloper-advocates-Contribution(PR #179, closed unmerged). The branch push fired notify-qa, which inferred the slug from the changed path and dispatched a QA rebuild. QA discovery reads the default branch, so the branch-only slug is a phantom → hard fail.Repeatable: every
validation-tutorial/*branch push (and any other feature-branch push touchingtutorials/**) fails QA the same way. Org scan: all 23-Contributionrepos ship the unfiltered template. The PROD flow is unaffected — every source repo'snotify-tutorials-ims.ymlalready carries the branch filter.Fix
Bring the QA template to parity with the PROD template (
docs/authors/tutorial-repo-dispatch.yml):branches: [master, main](both —Tutorials-Contributiondefaults tomaster, the rest tomain)Propagation
Template change alone does not fix the live repos. After merge, propagate with:
(idempotent; updates all 23
-Contributionrepos, PR-fallback on branch-protected ones).Clearing the failing issue
One clean full QA rebuild closes #2097: