Repository navigation
fix: use proper Hostname ssh_config casing - #45
Merged
Merged
Conversation
ssh_config(5) documents the keyword as Hostname. OpenSSH matches keywords case-insensitively, but tools that read the generated file case-sensitively do not find HostName.
francoisferrand
left a comment
francoisferrand
left a comment
There was a problem hiding this comment.
Instead of modifying platform-spawner, should we not modify SIT to be case-insenstive? That is a better long term fix, and does not require "bumping" platform-spawner...
Contributor
Author
The PR is also open. This is just a nice-to-have / hygiene since it was so simple to change. No need for a bump since we have the SIT PR. ie we can have both |
francoisferrand
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Just to be clear keys are case insensitive, so there is no issue on the SSH config itself.
But SIT tests that parse the
ssh_configare case sensitive, and they wantHostname, notHostName. (Could be fixed there also as needed). (See https://github.com/scality/artesca/pull/5627#discussion_r4245724944 for context) (Edit: I ended up also opening that PR https://github.com/scality/sit/pull/258)Hostnameis also the documented casing, so just for that it's acceptable "hygiene".What it does
Writes
Hostnamefor the bastion and the nodes, in both the runner'sssh_configand the one generated for the bastion, instead ofHostName.Should not have any impact whatsoever since keys are case insensitive.