Restore the swift-format gate: format the three files holding it open - #227
Merged
Conversation
DaemonBootstrap.swift's indentation (from the Linux-port commit, shipped in beta3) plus three spots in GitClient.swift and GraphOverviewCards.swift have failed `make check` on main since the Swift 6.3.3 toolchain's formatter started flagging them — 405 + 4 standing errors, so the release gate cannot be enforced. Output of `swift format format --in-place` under the repo configuration; `git diff -w` is empty everywhere except one guard re-wrapped in GitClient.swift, so no semantics move.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
make checkfails on main: 405 standing swift-format Indentation errors inGraphcodeKit/Sources/DaemonBootstrap.swift(introduced by the Linux-port commit 18feed8, already shipped in beta3 — surfaced when the Swift 6.3.3 toolchain's formatter started flagging them) plus 4 long-standing ones inGitClient.swiftandGraphOverviewCards.swift. With the gate red on main, the release check cannot be enforced.Fix
Output of
swift format format --in-placeunder the repo's.swift-formatconfiguration on exactly those three files. Nothing else touched:GraphcodeKit/Sources/DaemonBootstrap.swiftgit diff -wemptygraphcode/Sources/Features/Overview/GraphOverviewCards.swiftgit diff -wemptygraphcode/Sources/Clients/GitClient.swiftguardre-wrapped (same tokens); whitespace otherwiseswift format lint --recursive --strictis clean again acrossGraphcodeKit graphcode graphcode-cli graphcoded, and swiftlint stays green.