Repository navigation
Accept ip:port for --uri; bump to 2.8.4 - #198
Merged
Merged
Conversation
The release workflow's simulator check (synapsectl -u 127.0.0.1:50051 info) has been falling into name discovery and failing; it only passed before because failures exited 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--uri ip:port(e.g.127.0.0.1:50051) no longer goes through name discovery; only the host part decides name vs address. Bare IPv4/IPv6 still work.Why
The release workflow validates with
synapsectl -u 127.0.0.1:50051 infoagainst the simulator. That has been failing with "Device with name 127.0.0.1:50051 not found" since at least v2.8.2 — it only passed because the CLI exited 0 on failure. #194 made failures exit 1, so the v2.8.3 release stopped atvalidate-test-pypi-releaseand never published to PyPI.