Repository navigation
Mark scip-kotlin-bindings as an API dependency of scip-kotlin-analysis - #1073
Merged
Merged
Conversation
The KotlinAnalysisIndexer primary constructor and run method use org.scip_code.scip.Document in their public API. scip-java isn't impacted because it also brings the SCIP bindings via scip-aggregator.
Member
|
Sorry for only noticing this PR now, I hadn't set up proper notifications. Thank you for the fix, I'll add a smoke test to CI so that we'll notice these errors earlier in the future. |
christoph-sg
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The KotlinAnalysisIndexer primary constructor and run method use org.scip_code.scip.Document in their public API.
scip-java isn't impacted because it also brings the SCIP bindings via scip-aggregator.