Repository navigation
Document why the JVM does not exit after KotlinAnalysisIndexer.run - #1077
Closed
christoph-sg wants to merge 1 commit into
Closed
christoph-sg wants to merge 1 commit into
christoph-sg wants to merge 1 commit into
Conversation
The Analysis API starts IntelliJ's process-wide application thread pool, whose non-daemon core thread never stops and which cannot be shut down without breaking later runs in the same process. Amp-Thread-ID: https://ampcode.com/threads/T-01a1ca08-3e68-7113-8182-d86a4ef63ea7 Co-authored-by: Amp <amp@ampcode.com>
Member
Author
|
Don't think this really helps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Library users of
scip-kotlin-analysisfind that their JVM hangs afterKotlinAnalysisIndexer.run()returns.KaFirSessionProvidercreates IntelliJ's process-wideAppScheduledExecutorService, which immediately submits a task and keeps one non-daemon core thread alive for good. Itsshutdown()refuses to run on the global pool, and forcing it via reflection would break laterrun()calls in the same process, whichGradleBuildToolmakes once per Kotlin config. Disposing the session inrun()doesn't touch this pool. So this documents the explicitexitProcessrequirement on the class and points the two existingexitProcesscomments at the actual cause. No behavior change.