Skip to content

Add multi-arch builds for c10s and c9s pg18 images - #667

Closed
kkyrazis wants to merge 1 commit into
sclorg:masterfrom
kkyrazis:multi-arch-c10s
Closed

kkyrazis wants to merge 1 commit into
sclorg:masterfrom
kkyrazis:multi-arch-c10s

Conversation

@kkyrazis

@kkyrazis kkyrazis commented Aug 10, 2026 •

Copy link
Copy Markdown

Enables multi-arch builds for c10s postgres images.

Action run on my fork targeting only the c10s images.https://github.com/kkyrazis/postgresql-container/actions/runs/31413694674/job/93537569457:

End result in my quay repo: https://quay.io/repository/kkyrazis/postgresql-16-c10s

Fixes: #668

Assisted-by: Claude noreply@anthropic.com

Assisted-by: Claude <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 10, 2026 •

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The workflow now builds PostgreSQL 18 c9s and all c10s images with the multi-architecture path. The single-architecture path excludes these images and continues to process the remaining matrix entries.

Changes

Image build routing

Layer / File(s) Summary
Architecture-specific build selection
.github/workflows/build-and-push.yml
The multi-architecture build includes PostgreSQL 18 c9s and all c10s Dockerfiles. The single-architecture build excludes those Dockerfiles.

Estimated code review effort: 2 (Simple) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the multi-architecture build changes for c10s and c9s PostgreSQL 18 images, which matches the stated objectives.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 10, 2026 •

Copy link
Copy Markdown

Pull Request validation

Failed

🔴 Approval - missing or changes were requested

Success

🟢 CI - All checks have passed
🟢 Review - Reviewed by a member


Triggered by Workflow Run

@phracek phracek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why to build only C10S. So what about to build also the others?
The condition would be more readable.

@wgordon17

Copy link
Copy Markdown

@phracek superseded by #675 with removal of conditions completely (so we don't have to keep bumping versions)

@kkyrazis

kkyrazis commented Nov 9, 2026

Copy link
Copy Markdown
Author

Closing in favor of #675

@kkyrazis kkyrazis closed this Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

c10s images are not multi-arch while their corresponding c9s images are.

3 participants