feat: Restore discriminated variants in the Ruby SDK - #561
Merged
Conversation
razor-x
marked this pull request as ready for review
August 19, 2026 21:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
event_typeand action-attempt subclasses byaction_typeBaseResource.load_from_responsewithout changing sharedmergePropertiessemanticserror/resultnullability in YARDis_a?(SeamEvent)andis_a?(ActionAttempt)compatibility through inheritancemethodaccess toevent_methodso it no longer shadowsObject#methodCompatibility
This removes off-variant accessors that previously existed on flattened classes. Although variant instances remain subclasses of the existing base classes, this behavior change should receive a major-version decision before release.
Unknown event types, action types, error codes, and warning codes fall back to their generic base classes for forward compatibility.
Verification
npm run generatenpm run typechecknpm run lintrake lintrake test— 224 examples, 0 failures@seamapi/typesremains pinned at 1.1001.0. RBS signatures are intentionally left out of this change.