Repository navigation
chore: release v0.0.29 (EVM RPC keys) - #56
Merged
Merged
Conversation
Carries #54, which adds the 32 [evm] keys seid reads that the unified schema did not model, including per-IP rate limiting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PR SummaryLow Risk Overview Downstream consumers (e.g. sei-k8s-controller) can pin Reviewed by Cursor Bugbot for commit 366ecf4. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Suggested version: Changes in (empty)
Automatically created GitHub ReleaseA draft GitHub Release has been created. |
![seidroid[bot]](https://avatars.githubusercontent.com/in/2745135?s=60&v=4){kind=small}
There was a problem hiding this comment.
This bumps version.json from v0.0.28 to v0.0.29, which publishes a release containing #54 (the EVM RPC keys) and #55 (CI only). The remote's latest tag is v0.0.28, so this is the correct next version with no gap or collision, and nothing in the 9-line diff blocks it. Tests were not run because Go is not installed in this sandbox. The one other reader (codex) found nothing, and that matches this review.
seidroid review · decision approve · session 237e7ca1cd524f45b10deb33375fc225 · turn resp_claude_afc5ea385ad78f08aac718b840c0f686 · item b697d0d9a5f45d1a8ecfde2f70b642c3
Findings: 0 blocking | 0 non-blocking | 0 posted inline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
version.jsontov0.0.29.What it carries
[evm]keys seid reads thatSeiConfigdidn't model (PLT-1553)Why the keys matter
sei-k8s-controller renders node config through sei-config. Without these fields,
ApplyOverridesrejected keys such asevm.ip_rate_limit_rpsandevm.rate_limiting_enabledas unknown, andWriteConfigToDirdropped them fromapp.toml. Managed nodes could only run on seid's compiled-in defaults for rate limiting, request admission, filters and tracing.With this release:
evm.<seid key>overrides.Validate()catches startup failures. It rejects the values seid would refuse to start with.app.tomlwritten by v0.0.28 or earlier reads the missing keys as defaults instead of zeros, so an incremental apply can't writerate_limiting_enabled = falseormax_filters = 0back to a node.