-
Notifications
You must be signed in to change notification settings - Fork 192
docs: add contribution guide and code of conduct #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
6f366df
docs: add contribution guide and code of conduct
uniStark e7eaa75
docs: add contribution guide and code of conduct
uniStark 2b8164c
docs: add contribution guide and code of conduct
uniStark e5b8284
docs: add contribution guide and code of conduct
uniStark File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # Code of Conduct | ||
|
|
||
| The smallvec project follows the [Rust Code of Conduct](https://www.rust-lang.org/policies/code-of-conduct). | ||
| It applies to this repository, its issue tracker, pull requests, and other | ||
| official project spaces. | ||
|
|
||
| If you experience or witness unacceptable behavior, report it privately to the | ||
| Servo project maintainers through the contact method described in the | ||
| [Servo contribution guide](https://book.servo.org/contributing/getting-started). | ||
|
|
||
| Project participants are expected to be respectful, assume good faith, and | ||
| focus feedback on the work rather than on the person. Maintainers may remove | ||
| comments or contributions that violate this code and may take any other action | ||
| necessary to keep project spaces welcoming and productive. |
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same as above but with https://book.servo.org/contributing/getting-started |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Contributing to smallvec | ||
|
|
||
| Thank you for helping improve `smallvec`! Before opening a pull request, | ||
| please review the [Servo contribution guide](https://book.servo.org/contributing/getting-started). | ||
|
|
||
| ## Pull requests | ||
|
|
||
| - Keep changes focused and explain the motivation in the pull request. | ||
| - Add or update tests for behavior changes. | ||
| - Run the relevant Rust formatting, test, and lint checks locally. | ||
| - Do not include generated files, credentials, or unrelated formatting changes. | ||
|
|
||
| Please be patient during review. Maintainers may ask for revisions so that a | ||
| change remains compatible with the supported Rust versions and the crate's | ||
| API guarantees. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be better if we simply copy-paste https://servo.org/coc/
it's markdown-ish
and that way there's no worry about having changed the wording in a way that changes policy in some way