Repository navigation
Conversation
There was a problem hiding this comment.
Thanks for your contribution, I did some quick testing and it looks like there are a few bugs with the current code:
- An outgoing message lands 8dp to the right of where it was (screenshot 1)
- In RTL languages, the message moves sideways by the width of its timestamp (incoming messages can end up at or past the right edge) (screenshot 2 - with force RTL enabled)
- The reaction bar can be covered by the context menu (screenshot 3)
- When the menu closes the message slides in the wrong direction before snapping back to the original position (video 1)
video 1
https://github.com/user-attachments/assets/d5724c24-78e6-4676-8c6e-04697ec06b54
|
Thanks for testing and catching those @mpretty-cyro! Fixed all 4 issues in the latest commit:
Verified with |
|
also noticed another bug when the keyboard is open and you long press the last sent/received message. hideKeyboard() was closing the keyboard after we already grabbed bubbleY, so the recyclerview would resize/drop down while the overlay snapshot stayed up at the old spot (causing a duplicate bubble sticking out underneath). i kept the keyboard as-is when long pressing and added WindowInsetsCompat.Type.ime() to the overlay insets so the reaction bar and context menu stay above the keyboard instead. let me know if you want screenshots of what was happening before |
|
also clipped the overlay message snapshot to the recyclerview's visible bounds. before this, if a tall message was partially scrolled under the top app bar or behind the input bar, the unclipped bitmap would draw over them. now it stays strictly within the chat list area between the top bar and input bar/keyboard |



First time contributor checklist
Fixes #1234syntaxDescription
Previously, when long-pressing a message in the conversation view to open the reaction bar and context menu,
ConversationReactionOverlayforcefully shifted the bubble across the screen (snapping it to margin edges), scaled down the bubble snapshot, and ran translation/scaling animations. This displaced the message away from the user's touch and from its position in the chat list.This PR aligns the overlay interaction with standard modern messaging UX (like WhatsApp / Telegram):
(bubbleX, bubbleY)in local coordinates at1.0fscale, without translation or scale animations.Testing:
compilePlayDebugKotlin,compilePlayDebugJavaWithJavac, andtestPlayDebugUnitTestall pass.