Add missing refresh rates modes for DOS - #6
Open
maraakate wants to merge 1 commit into
Open
Conversation
… support to all the modes by setting the correct things in the table.
Owner
|
@dborca : Is this OK? |
Author
|
I think this is OK. It looks like they just focused on having STB come up with some additional CRTC modes to add and they just never copied them into the if def/else/endif. Been using it for a couple of days now with zero issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
H4=1 in the mode table did not have the additional ones for 100hz and 120hz. They're in the alternate codepath in this file. Just copy them back in. Tested on a real CRT.
Note that there is an opportunity here to add 100hz and 120hz to the higher modes that never had them in this table. I'd have to run some tools to calculate the settings, but may be worth doing in the future for someone who might want 100 or 120hz on 640x400 for example.