SG-43999: add custom entity config features - #456
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #456 +/- ##
==========================================
+ Coverage 78.76% 79.18% +0.41%
==========================================
Files 7 7
Lines 1851 1869 +18
==========================================
+ Hits 1458 1480 +22
+ Misses 393 389 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
575eb08 to
c272359
Compare
c272359 to
2c2e95f
Compare
| self._ensure_support( | ||
| {"version": (8, 88, 0), "label": "custom entity config API"} | ||
| ) |
There was a problem hiding this comment.
notes: this version should be updated with the correct version once the feature is rolled out
| Shotgun.custom_entity_read | ||
| Shotgun.custom_entity_enable | ||
| Shotgun.custom_entity_configure | ||
| Shotgun.custom_entity_disable |
There was a problem hiding this comment.
I don't see the point having enable and disable action as API.
Basically, we want a CRUD for these custom entities. I don't know if Create and Delete are part of the scope. So basically, that should give us only 2 API methods:
- custom_entity_read
- custom_entity_update (display_name, status/enable/disable, ...)
Now, we might want to keep the custom_entity_enable and custom_entity_disable Python method as shortcuts to call custom_entity_update but then there should not be anything about display name in there.
This PR introduces 4 new functions that allow users to configure custom entity (previously can only be done through the UI):
Should only be merged when these methods are supported in FlowPT (once other PRs in SG-43999 are merged)