Repository navigation
Conversation
alexa-sift
reviewed
Oct 16, 2026
bill-sift
force-pushed
the
add-file-attachment-tools
branch
2 times, most recently
from
November 17, 2026 21:33
567aadc to
06f8388
Compare
bill-sift
force-pushed
the
add-file-attachment-tools
branch
from
November 18, 2026 17:28
06f8388 to
0cfc4a0
Compare
ListRemoteFiles page tokens now advance and order_by is honored, so list_file_attachments follows tokens up to the limit and passes order_by through. Backends without that fix answer a later token with rows already returned, so paging stops at the first page with no new row.
liam-sift
reviewed
Nov 19, 2026
| .into_iter() | ||
| .filter(|file| seen.insert(file.remote_file_id.clone())) | ||
| .peekable(); | ||
| if new_files.peek().is_none() { |
Contributor
There was a problem hiding this comment.
An empty page here would stop paging, is it possible that a page is empty because a user doesn't have access to any of those files and the paging stops early? Could maybe stop when the token repeats, but I could be overthinking this...
Contributor
|
Maybe this just goes into azimuth now? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new tools to add file attachment support into the MCP server
list_file_attachmentsfor runs, assets, annotations and comments, test reports, and test steps. other attachment types that have separate tools like artifacts and chat uploads aren't shown.download_file_attachmentreturns a signed URL for a file