Skip to content

rust(feat): add file attachment tools to the MCP server - #836

Open
bill-sift wants to merge 4 commits into
mainfrom
add-file-attachment-tools
Open

bill-sift wants to merge 4 commits into
mainfrom
add-file-attachment-tools

Conversation

@bill-sift

Copy link
Copy Markdown
Contributor

Added new tools to add file attachment support into the MCP server

  • list_file_attachments for runs, assets, annotations and comments, test reports, and test steps. other attachment types that have separate tools like artifacts and chat uploads aren't shown.
  • download_file_attachment returns a signed URL for a file
  • reference both in the sift skill

@bill-sift
bill-sift force-pushed the add-file-attachment-tools branch 2 times, most recently from 567aadc to 06f8388 Compare November 17, 2026 21:33
@bill-sift
bill-sift force-pushed the add-file-attachment-tools branch from 06f8388 to 0cfc4a0 Compare November 18, 2026 17:28
ListRemoteFiles page tokens now advance and order_by is honored, so list_file_attachments follows tokens up to the limit and passes order_by through. Backends without that fix answer a later token with rows already returned, so paging stops at the first page with no new row.
.into_iter()
.filter(|file| seen.insert(file.remote_file_id.clone()))
.peekable();
if new_files.peek().is_none() {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An empty page here would stop paging, is it possible that a page is empty because a user doesn't have access to any of those files and the paging stops early? Could maybe stop when the token repeats, but I could be overthinking this...

@liam-sift

Copy link
Copy Markdown
Contributor

Maybe this just goes into azimuth now?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants