Skip to content

rust(feat): add list_webhooks and webhook_ids on create_rule and update_rule - #837

Merged
bill-sift merged 1 commit into
mainfrom
mcp-rule-webhooks
Nov 17, 2026
Merged

bill-sift merged 1 commit into
mainfrom
mcp-rule-webhooks

Conversation

@bill-sift

@bill-sift bill-sift commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Agents could not see or attach webhooks, so a request to alert someone when a rule fires lost its notification step.

  • New list_webhooks tool over ListWebhooks. The backend returns credentials in plaintext, so the tool keeps only the target URL's scheme and the last two labels of its host, header names, and no body template.
  • create_rule and update_rule items take webhook_ids. On update_rule it replaces the rule's set, like asset_ids; omitted, the current webhooks are kept, even through a conditions_json rewrite. The item's warning names any webhook detached.
  • Both tools confirm each webhook exists and is not archived before writing, since Sift accepts an archived webhook on a rule and never calls it. update_rule checks only newly attached webhooks, so passing a rule's current set back is always safe. A missing or archived webhook fails only its item.
  • Webhook actions written into the conditions are refused so none skips that check, including an action typed WEBHOOK with no configuration.
  • create_rule documents the annotation action shape, and both tools check for exactly one condition. Sift answers a rule with none with an internal error.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Python docs preview: https://sift-stack.github.io/sift/python/pr-837/

Deployed from 5dafc97. The link may take up to a minute to become live as GitHub Pages propagates.

@bill-sift
bill-sift requested a review from bijan-sift October 15, 2026 18:01
bijan-sift
bijan-sift previously approved these changes Oct 15, 2026
bijan-sift
bijan-sift previously approved these changes Oct 15, 2026
…te_rule

Agents could not see or attach webhooks, so a request to alert someone when a
rule fires lost its notification step.

- New list_webhooks tool over ListWebhooks. The backend returns credentials in
  plaintext, so the tool keeps only the target URL's scheme and the last two
  labels of its host, header names, and no body template.
- create_rule and update_rule items take webhook_ids. On update_rule it
  replaces the rule's set, like asset_ids; omitted, the current webhooks are
  kept, even through a conditions_json rewrite. The item's warning names any
  webhook detached.
- Both tools confirm each webhook exists and is not archived before writing,
  since Sift accepts an archived webhook on a rule and never calls it.
  update_rule checks only newly attached webhooks, so passing a rule's current
  set back is always safe. A missing or archived webhook fails only its item.
- Webhook actions written into the conditions are refused so none skips that
  check, including an action typed WEBHOOK with no configuration.
- create_rule documents the annotation action shape, and both tools check for
  exactly one condition. Sift answers a rule with none with an internal error.

@liam-sift liam-sift left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@bill-sift
bill-sift merged commit c2f91f1 into main Nov 17, 2026
22 checks passed
@bill-sift
bill-sift deleted the mcp-rule-webhooks branch November 17, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants