Repository navigation
rust(feat): add list_webhooks and webhook_ids on create_rule and update_rule - #837
Merged
Merged
Conversation
bijan-sift
reviewed
Oct 15, 2026
Contributor
|
Python docs preview: https://sift-stack.github.io/sift/python/pr-837/ Deployed from |
bijan-sift
previously approved these changes
Oct 15, 2026
bijan-sift
previously approved these changes
Oct 15, 2026
bill-sift
force-pushed
the
mcp-rule-webhooks
branch
from
November 17, 2026 20:37
43dbad8 to
1999fdb
Compare
…te_rule Agents could not see or attach webhooks, so a request to alert someone when a rule fires lost its notification step. - New list_webhooks tool over ListWebhooks. The backend returns credentials in plaintext, so the tool keeps only the target URL's scheme and the last two labels of its host, header names, and no body template. - create_rule and update_rule items take webhook_ids. On update_rule it replaces the rule's set, like asset_ids; omitted, the current webhooks are kept, even through a conditions_json rewrite. The item's warning names any webhook detached. - Both tools confirm each webhook exists and is not archived before writing, since Sift accepts an archived webhook on a rule and never calls it. update_rule checks only newly attached webhooks, so passing a rule's current set back is always safe. A missing or archived webhook fails only its item. - Webhook actions written into the conditions are refused so none skips that check, including an action typed WEBHOOK with no configuration. - create_rule documents the annotation action shape, and both tools check for exactly one condition. Sift answers a rule with none with an internal error.
bill-sift
force-pushed
the
mcp-rule-webhooks
branch
from
November 17, 2026 20:40
1999fdb to
1096cc8
Compare
liam-sift
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents could not see or attach webhooks, so a request to alert someone when a rule fires lost its notification step.