Repository navigation
rust(feat): keep a run open across file imports - #889
Merged
Merged
Conversation
4 tasks done
`import` accepts `--leave-run-open`. A finished import marks its run stopped unless the flag is set. The import docs point at one Python call when several files share a run.
--run creates a new run each time, because run names are not unique. --run-id adds a file to the run left open by --leave-run-open. The other import builders read that flag from the shared args.
ian-sift
force-pushed
the
file-upload-leave-run-open-cli
branch
from
November 16, 2026 23:08
02a6ec9 to
e058e61
Compare
ian-sift
enabled auto-merge (squash)
November 16, 2026 23:08
alexluck-sift
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sift-cli importaccepts--leave-run-openfor CSV, TDMS, HDF5, ULog, MCAP, and Parquet. A finished import marks its run stopped unless the flag is set. Stop the run after the last import. The flag does nothing when the import has no run.import csvaccepts--run-id.--runcreates a new run each time, because run names are not unique. Use--run-idto add a file to a run left open by--leave-run-open.--run-id, not a repeated--run.Test plan
cargo test -p sift_cli --bin sift-cli import::passed 183 tests, covering CSV, Parquet, TDMS, HDF5, ULog, and MCAPleave_run_openon the built upload request. The CSV test also asserts--run-idlands on the request and leaves the run name empty.sift-cli import csvof one CSV and of two CSVs against the local backendLocal verification
Built
sift-clifrom this branch and imported against the local backend (localhost:50051/localhost:8080) with--disable-tls --wait.rust-cli-one-c0ae6f7c, runrust-cli-one-c0ae6f7c: the command exited 0. The import status isSUCCEEDED. The run is stopped. The asset has channelvoltage.rust-cli-pair-81777058, both commands using--run rust-cli-pair-81777058: both commands exited 0 and both imports areSUCCEEDED.a.csvwith--leave-run-openleft its run open (780d905b-0a2a-429d-81b2-bdbeba93a4af, channelvoltage_a).b.csvwithout the flag created a second run of the same name and stopped it (bacb03ac-8e6c-4dea-8196-118438022a38, channelvoltage_b). The CSV importer gives each--runname a new client key, so the second file does not attach to the open run.The docs now tell the second command to pass
--run-idof that open run. A multi-file CLI upload is still the Python client's job.