Skip to content

sift(chore): update public protos - #890

Merged
omar-sift merged 3 commits into
mainfrom
protos/support-custom-date-formats
Nov 14, 2026
Merged

omar-sift merged 3 commits into
mainfrom
protos/support-custom-date-formats

Conversation

@omar-sift

@omar-sift omar-sift commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Commit SHA: 204eaa0fcc

Syncs the public protos and the generated Go, Python, and Rust code. Six proto files change. Nothing is removed or renamed.

Notable changes:

  • Data imports: TIME_FORMAT_CUSTOM, and custom_format on CsvTimeColumn and ParquetTimeColumn. custom_format is a Unix date format string, such as %m-%d-%Y %H:%M:%S, and is used only with TIME_FORMAT_CUSTOM.
  • Artifacts: ARTIFACT_ENTITY_TYPE_CANVAS_EXECUTION
  • Canvas: CanvasService is declared with no methods. Its only method, ExportCanvas, and its request and response messages are unstable, so sanitizing strips them. This adds canvas_vtproto.pb.go and sift.canvas.v1.tonic.rs, which hold client and server boilerplate for a service with no RPCs.
  • Data (v1 and v2): the run_id docs on ChannelQuery and CalculatedChannelQuery now describe the current behavior. On ChannelQuery, an empty string is treated the same as unset. On CalculatedChannelQuery, an empty string returns all run and non-run data as one combined result. When unset, both return all data split by run.
  • Channels (v3): comment-only change

Code outside the generated output:

  • sift_cli: the CSV and Parquet TimeColumn initializers set custom_format to its default, so the crate still compiles with the new field
  • python/changelog.d/890.chore.md

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Python docs preview: https://sift-stack.github.io/sift/python/pr-890/

Deployed from 4421759. The link may take up to a minute to become live as GitHub Pages propagates.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@omar-sift
omar-sift requested a review from wei-sift November 13, 2026 23:28
@omar-sift
omar-sift marked this pull request as ready for review November 13, 2026 23:28
wei-sift
wei-sift previously approved these changes Nov 14, 2026

@wei-sift wei-sift left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@omar-sift
omar-sift merged commit 80ac3b7 into main Nov 14, 2026
27 checks passed
@omar-sift
omar-sift deleted the protos/support-custom-date-formats branch November 14, 2026 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants