Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sift's import examples cover CSV, HDF5, MCAP and Parquet, but nothing for MAVLink, which is what PX4 and ArduPilot vehicles speak. The usual drone flight record is a
.tlogfrom QGroundControl, Mission Planner or MAVProxy: every MAVLink frame behind the microsecond time the ground station got it. Today a Sift user with one of those has to write their own MAVLink framer before they can stream anything.This adds
rust/crates/sift_stream/examples/mavlink-tlog/main.rs:mavlinkcrate (common dialect only)GLOBAL_POSITION_INT,ATTITUDEandSYS_STATUSas three flows, in degrees, metres, m/s, volts, amps and percent, each with the frame's recorded timestamp, notTimeValue::now()linkflow sends received / lost / duplicate frame counts and loss % once per second of log time, worked out from MAVLink sequence numbers, so link health shows up next to the flight dataMAVLINK_SYSTEM_IDpicks the vehicle (default 1),SIFT_ASSET_NAMEnames the assetmavlinkandmavlink-tlogare added as dev-dependencies ofsift_streamonly (and to[workspace.dependencies]), so nothing changes for anyone depending onsift_stream.How I checked it: I ran the example's replay function against the mock server in
tests/commonwith a recordingIngestService, on three logs:log.tlog(real recording, 11.5 s)cargo test -p sift_stream --all-featurespasses, andcargo clippy -p sift_stream --all-targets --all-featuresandcargo fmt --check --allare clean.I maintain mavlink-tlog (MIT, MSRV 1.70, no dependencies). It checks the CRC of every message in MAVLink's all.xml, recovers from damaged logs, and its counts are tested against pymavlink. I'll keep it current.
I saw CONTRIBUTING says outside PRs get closed. If you'd rather re-land this yourselves the way #469 went in as #474, that's completely fine with me.