Repository navigation
Conversation
Change-Id: Ib4fe0cf04496ffdb44f4c2a6d11f36a8694ac409
NUnit Tests 1 files ± 0 1 suites ±0 14m 45s ⏱️ -1s Results for commit fd6340a. ± Comparison against base commit 2d21d16. This pull request removes 1 and adds 46 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1225 +/- ##
==========================================
+ Coverage 39.93% 40.43% +0.50%
==========================================
Files 1542 1552 +10
Lines 355165 355849 +684
Branches 41317 41531 +214
==========================================
+ Hits 141833 143897 +2064
+ Misses 183999 182641 -1358
+ Partials 29333 29311 -22
🚀 New features to boost your workflow:
|
Change-Id: If4150ba3a95346b9cc4747bd811793d6587b0816
| regkey.SetValue(m_strMaxAmbiguities, MaxAmbiguities); | ||
| regkey.SetValue(m_strTimeLimit, TimeLimit); | ||
| regkey.SetValue(m_strRunIndividually, RunIndividually); | ||
| regkey.SetValue(m_strShowFailures, ShowFailures); |
There was a problem hiding this comment.
Show Failures setting carries over between sessions
The Show Failures choice is saved to the registry and restored the next time PcPatrFLEx opens. Nothing in the main window shows that a debug mode is still on. The same setting also applies when Disambiguate is clicked, which runs the whole text and writes the results back into the FLEx project.
Example: a user switches to "Only use phrase structure rules" to find out why one segment won't parse, then closes the tool. A week later they disambiguate a text. PC-PATR ignores every feature constraint, and the resulting analyses are written into the text. With "Use phrase structure rules and all constraints" on a full grammar, the run can take a very long time, as the documentation warns.
Possible fixes:
- Don't save the setting, so every launch starts at Off. Since these are debugging modes, this is the safer default.
- Keep saving it, but ask the user to confirm before Disambiguate runs while a debug mode is on.
If there's a reason to keep the setting across sessions, either fix still prevents a whole text from being disambiguated in a debug mode by accident.
There was a problem hiding this comment.
Good points! I'll work on a soluton.
We also need to add some more documentation we're working on.
Change-Id: I5261538de08b6ac14b216b848a9d77b4ea770761
This adds three options to the advanced menu of the Use PcPatr with FLEx utility. The first option is what we have been using. The two new ones are for debugging a PC-PATR grammar. They change the content of the PcPatrFLEx.tak file.
It adds four new items to the PCPATR custom list.
The change also includes enhancements to the user documentation.
This change is