Repository navigation
Move Delete to the menu and name the source in project dialogs - #594
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
3c85325 to
2b6bd7c
Compare
2b6bd7c to
56823d4
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
imnasnainaec
left a comment
There was a problem hiding this comment.
@imnasnainaec reviewed 4 files and all commit messages, and resolved 3 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on mikelothers).
alex-rawlings-yyc
left a comment
There was a problem hiding this comment.
@alex-rawlings-yyc made 3 comments.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on mikelothers).
contributions/localizedStrings.json line 384 at r1 (raw file):
Previously, imnasnainaec (D. Ror.) wrote…
⛏️ Pre-existing count-mismatch: "in the book's titles or introduction"
It may be correct if a book can have multiple titles, but even if not inaccurate, one of the following reads better:
- "in the book titles or introductions"
- "in a book's title or introduction"
Changed to "in book titles or introductions".
src/components/modals/ProjectMetadataModal.tsx line 215 at r1 (raw file):
Previously, imnasnainaec (D. Ror.) wrote…
⛏️ Pre-existing but in-scope bug: the text wraps mid-word, e.g.:
Fixed. The read-only rows used break-all, so they now use break-words: text wraps at spaces, and a long unbroken value still wraps instead of overflowing.
src/components/modals/Pt9ImportModal.tsx line 320 at r1 (raw file):
Previously, imnasnainaec (D. Ror.) wrote…
❓ This is likely out-of-scope, but why don't the numbers match up? E.g.
has 352,422 - 291,971 --?--> 53,819 --?--> 45,861 + 7,435
Two gaps. The total includes phrase clusters, which are counted in the ", N phrases" figure after the cluster count (cut off in your screenshot) rather than in the 291,971. The list also named only the top two drop reasons, so the remaining 523 were in reasons it hid. It now lists every nonzero reason, so the bullets sum to the "Not imported" count.
imnasnainaec
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on mikelothers).


Resolves #590
Screenshots
PT9 import prompt

Import progress

Import report

Project menu

Interlinear info, editable project

Interlinear info, PT9 import

Delete confirmation

🤖 Generated with Claude Code
This change is