Skip to content

Move Delete to the menu and name the source in project dialogs - #594

Merged
alex-rawlings-yyc merged 2 commits into
mainfrom
590-update-project-info-import-delete-dialogs
Nov 3, 2026
Merged

alex-rawlings-yyc merged 2 commits into
mainfrom
590-update-project-info-import-delete-dialogs

Conversation

@alex-rawlings-yyc

@alex-rawlings-yyc alex-rawlings-yyc commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Resolves #590

  • Interlinear info is titled "Interlinear info: {source}". The project ID and source project rows are gone, and so is the Delete button.
  • Delete… is a Project menu item of its own, shown once a project is active.
  • The PT9 prompt and the import dialogs name the source. The progress dialog shows only its title, "Importing interlinear data from Paratext 9: {source}…".
  • The import report lists its not-imported reasons as bullets, and its counts are locale-formatted.
  • An import is named "Paratext 9 Interlinear: {source}" and gets the new read-only description. Copy to editable prefills a matching editable description.
  • Menu items are in sentence case: "Select interlinear…", "New interlinear…", "Interlinear info…", "Analysis catalog".

Screenshots

PT9 import prompt
1-pt9-prompt

Import progress
2-pt9-progress

Import report
3-pt9-report

Project menu
4-menu

Interlinear info, editable project
5-info-editable

Interlinear info, PT9 import
6-info-import

Delete confirmation
7-delete-confirm

🤖 Generated with Claude Code


This change is Reviewable

@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c4a45c86-4d87-4211-98c0-87dd3e4d54de
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@alex-rawlings-yyc
alex-rawlings-yyc force-pushed the 590-update-project-info-import-delete-dialogs branch from 3c85325 to 2b6bd7c Compare November 2, 2026 22:15
@alex-rawlings-yyc
alex-rawlings-yyc force-pushed the 590-update-project-info-import-delete-dialogs branch from 2b6bd7c to 56823d4 Compare November 2, 2026 22:37
imnasnainaec

This comment was marked as resolved.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@imnasnainaec imnasnainaec left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imnasnainaec reviewed 4 files and all commit messages, and resolved 3 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on mikelothers).

@alex-rawlings-yyc alex-rawlings-yyc left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alex-rawlings-yyc made 3 comments.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on mikelothers).


contributions/localizedStrings.json line 384 at r1 (raw file):

Previously, imnasnainaec (D. Ror.) wrote…

⛏️ Pre-existing count-mismatch: "in the book's titles or introduction"

It may be correct if a book can have multiple titles, but even if not inaccurate, one of the following reads better:

  • "in the book titles or introductions"
  • "in a book's title or introduction"

Changed to "in book titles or introductions".


src/components/modals/ProjectMetadataModal.tsx line 215 at r1 (raw file):

Previously, imnasnainaec (D. Ror.) wrote…

⛏️ Pre-existing but in-scope bug: the text wraps mid-word, e.g.:

image.png

Fixed. The read-only rows used break-all, so they now use break-words: text wraps at spaces, and a long unbroken value still wraps instead of overflowing.


src/components/modals/Pt9ImportModal.tsx line 320 at r1 (raw file):

Previously, imnasnainaec (D. Ror.) wrote…

❓ This is likely out-of-scope, but why don't the numbers match up? E.g.
image.png
has 352,422 - 291,971 --?--> 53,819 --?--> 45,861 + 7,435

Two gaps. The total includes phrase clusters, which are counted in the ", N phrases" figure after the cluster count (cut off in your screenshot) rather than in the 291,971. The list also named only the top two drop reasons, so the remaining 523 were in reasons it hid. It now lists every nonzero reason, so the bullets sum to the "Not imported" count.

@imnasnainaec imnasnainaec left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on mikelothers).

@alex-rawlings-yyc
alex-rawlings-yyc merged commit 9874e1f into main Nov 3, 2026
16 checks passed
@alex-rawlings-yyc
alex-rawlings-yyc deleted the 590-update-project-info-import-delete-dialogs branch November 3, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update project info, import, delete dialogs

2 participants