Skip to content

Add a conformance suite for HermitCrab, with its adequacy argument - #480

Closed
johnml1135 wants to merge 113 commits into
fix/signature-drops-id-under-identity-rulefrom
integrate-conformance-framework
Closed

johnml1135 wants to merge 113 commits into
fix/signature-drops-id-under-identity-rulefrom
integrate-conformance-framework

Conversation

@johnml1135

@johnml1135 johnml1135 commented Aug 19, 2026 •

Copy link
Copy Markdown
Collaborator

Start here: conformance/docs/what-it-is.md, then .github/workflows/conformance.yml: what the suite claims and the gate that enforces it.

Status: stacked on #500 — merge in order #556 → #500 → #480 → #578.

Status: CI is red at head 262ab300. Both Build jobs fail ConformanceFixtureGateTests.EveryConformanceFixturePassesSelfCheck on four edge-cases/truncate-morphotactic* fixtures (word analyses differ from expectation), and both Conformance jobs fail, with the workflow reporting conformance/coverage.csv or rules.csv stale against the fixtures. The branch is behind master. Work is held until after the Hermit Crab Optimizations release; nothing stacks on this PR.

A conformance suite of synthetic HermitCrab grammars, run in-process with HermitCrab as the oracle, with CI gates for parse results, coverage claims and generated ledgers. The latest revision adds named parser-settings variants: the runner builds a fresh morpher per run, applies the variant's settings, and compares complete parse-identity multisets and statuses against that run's own expectations. Variants earn no fixture or semantic-coverage credit.

Why is it so big? The change is about 940 files. Harness code and its tests are the reviewable part; the rest is fixtures, generated ledgers and evidence cards, and docs. Generated files are rewritten by hc-conformance --write-* and pinned by tests, so check freshness, do not read line by line. No parser engine changed.

Where to look:

  • .github/workflows/conformance.yml: the gate (self-check, coverage report, freshness of generated CSVs).
  • conformance/dead-rules-allowed.tsv: a rule no word exercises fails the coverage report unless listed with a reason.
  • conformance/PROTOCOL.md and WordsYamlLoader.cs: the adapter contract; settings are closed, so an unsupported setting fails rather than being silently ignored. Pinned by WordsYamlMorpherSettingsTests.
  • src/SIL.Machine.Morphology.HermitCrab.Conformance/Runner.cs: self-check.
  • global.json: new; pins SDK 10.0.100 with latestFeature roll-forward for the whole repository.

Deliberately not here: MaxAlternatives (PanGloss lacks HC's typed overflow behaviour) and MergeMSAs (needs the FieldWorks project loader) are unsupported variant settings. MergeAnalyses verifies output preservation only, not merge-fold counts. Suite-side work for #534 (open) waits for its merge.

Verification: the earlier numbers (local_check.sh --agent-strict, C# and PanGloss variant matrices) were taken at 184bcd46, not at the current head, and are not repeated here; the red jobs above are the current evidence. Broader Rust workspace and Foma suites were not run.

Next: fix the four truncate-morphotactic* fixtures and regenerate the CSVs, then rebase; or say if the red gate should block holding this branch.


Reading this a year from now -- start here

The suite is an executable adequacy argument: synthetic grammars whose expected parse-identity multisets are checked against HermitCrab (self-check) and against a second engine (PanGloss) through an adapter protocol. The decisions below explain why the gates look the way they do.

Decisions and why
  • Variants as run-level settings. Settings come from constructor defaults and per-call GuessRoots; supported: DelReapps, MaxRoots, MakePartialsFinal, MergeAnalyses, GuessRoots. The main risk is claiming support for a setting an adapter cannot apply or treating incomplete output as an empty result, so unsupported settings, missing rows and zero-comparison variants fail, and PanGloss also rejects capped or timed-out output.
  • Source-generator loading. PCRE.NET ships an IIncrementalGenerator; the compilation-graph loader admits it only by content hash, and a probe runs it and fails closed on any generated output.
  • Crash fixtures. An expect_crash fixture passes only if the same engine completes an ordinary fixture in the same run, so a broken adapter command cannot pass as a crash (conformance/PROTOCOL.md).
  • Binary .fwdata. Marked binary in .gitattributes because its pinned hash depended on core.autocrlf. Four fixture grammars keep trailing whitespace because their hashes are pinned in the manifest. Hand-maintained fixture totals were removed from docs; the manifest is the count.
  • Trace.FailureAllomorph dropped. An engine API change does not belong in a test-suite PR; Trace HermitCrab failure reasons and template slot outcomes #534 adds the same fact through its own trace field.
  • ci.yml back to master. Its added fixture run duplicated ConformanceFixtureGateTests under dotnet test.
Surprising findings
  • The coverage report could not fail; it now gates dead rules and uncovered constructs.
  • The counterfactual sweep read mutant output in the console code page, so a mutation that changed nothing looked like evidence. It now reads UTF-8 (CounterfactualGate, with a regression test). Regenerating the ledger demoted two surfaces that had only that false evidence (Gloss to Unobservable, HeadFeatures to RequiredByDtd).
  • local_check.sh ran --semantic-coverage, which exits 1 by design while the catalog is incomplete, so it could never pass; it now runs the same gates as conformance.yml.
  • chained-output-feature-override-loss claimed to fail on master on purpose; it has passed since Change Add to PriorityUnion #494 (merged).
Deferred, and what would unblock it

#540, #522 and #519 are merged and #543 is closed; their suite-side work is already in this branch or no longer stacks here. #534 is open: once it merges, FailureRuleAttributor should credit through its new trace field and the FieldWorks-producibility ledger needs rows for its four new failure reasons. #543 would have added fixtures for the #504 and #507 evidence gaps; they are not in this branch. Unsupported variant settings (MaxAlternatives, MergeMSAs) need PanGloss overflow behaviour and a FieldWorks project loader respectively.

Evidence and oracle observations

C# HC observations for the variants were collected on 2026-10-22 with the engine unchanged; the five measured fixture/settings pairs cover deletion reapplications (DelReapps), compounding breadth (MaxRoots), final-template partial discriminators (MakePartialsFinal), the final-template merge key (MergeAnalyses) and guess-roots (GuessRoots). Exact witness outputs and reproduction commands are in conformance/docs/parser-settings-variants.md. The variant protocol forbids capped or timed-out output from matching an expected empty result; the PanGloss tests include that negative control. The companion PanGloss adapter was tested at e2627c9 on feat/conformance-settings-variants. Counts quoted in earlier revisions of this description (tests, runs, fixtures, words) were taken at an older head and are not carried forward.

🤖 Generated with Claude Code


This change is Reviewable

@johnml1135
johnml1135 requested a review from ddaspit August 19, 2026 19:27
@johnml1135
johnml1135 force-pushed the integrate-conformance-framework branch from d826869 to 8f9dcea Compare August 19, 2026 19:46
@codecov-commenter

codecov-commenter commented Aug 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.78%. Comparing base (b86120f) to head (69c4ee0).
⚠️ Report is 1 commits behind head on fix/signature-drops-id-under-identity-rule.

Additional details and impacted files
@@                              Coverage Diff                               @@
##           fix/signature-drops-id-under-identity-rule     #480      +/-   ##
==============================================================================
+ Coverage                                       74.62%   74.78%   +0.16%     
==============================================================================
  Files                                             453      556     +103     
  Lines                                           38345    56544   +18199     
  Branches                                         5285     7722    +2437     
==============================================================================
+ Hits                                            28614    42289   +13675     
- Misses                                           8568    12360    +3792     
- Partials                                         1163     1895     +732     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@johnml1135
johnml1135 force-pushed the integrate-conformance-framework branch 2 times, most recently from d0b5448 to 9dfb2f6 Compare August 20, 2026 09:10
@johnml1135
johnml1135 force-pushed the integrate-conformance-framework branch 2 times, most recently from de95458 to 4823a05 Compare September 4, 2026 00:15
johnml1135 added a commit that referenced this pull request Sep 15, 2026
Introduces an engine-agnostic conformance suite for HermitCrab-formalism
morphological parsers: a `conformance/` tree of language grammars and
edge-case micro-grammars, each an HC-XML grammar.xml paired with a
words.yaml ground truth (oracle-provenance, gloss, and per-word parse
signatures). A new SIL.Machine.Morphology.HermitCrab.Conformance project
and hc-conformance CLI tool run those fixtures against an engine adapter,
producing coverage and rules CSVs, an interface inventory, dataflow-
obligation ledgers, evidence cards, a FieldWorks-producibility table, and
a JSON manifest for external consumers. PROTOCOL.md is the adapter
contract a second engine (e.g. the in-progress Rust port) implements to
plug into the same suite.

Includes the FieldWorks-producibility classification campaign: for every
HermitCrab construct the suite covers, a verdict on whether FieldWorks'
own HC-XML export path can actually produce a grammar exercising it,
distinguishing genuine data-model limits from mere loader gaps, with five
previously-unresolved verdicts now classified and corrected write-ups for
two more cases initially misread as exporter silence.

Also lands one new edge-case fixture,
edge-cases/chained-output-feature-override-loss, isolating an analysis-
side OutputHeadFeatures retraction bug: a well-formed four-morph parse of
`zudiua` that the founding C# oracle currently loses. The fixture is
deliberately red against hc.dll today (expected, not a broken test) and
documents the mechanism, provenance, and the HC-Rust divergence that
motivated it.

The suite is deliberately stopped at this point rather than finished:
scope, known gaps, and next steps are documented in the suite's own
tracking docs rather than left implicit.

This commit squashes the full conformance-suite branch stack
(integrate-conformance-framework through conformance/fieldworks-
witnesses, 49 commits) into one commit on top of current master, for
PR #480.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@johnml1135
johnml1135 force-pushed the integrate-conformance-framework branch from 4823a05 to 3128301 Compare September 15, 2026 12:29
johnml1135 added a commit that referenced this pull request Sep 15, 2026
Records a break-attempt run of PR #494 (AnalysisAffixProcessRule fix)
against the conformance suite: 36/36 fixtures pass (including
pathological cases), and a generated-word fuzz sweep (every root x
every 0..3-subset of affix rules, up to 6 nonhead roots where the
grammar compounds) produced ~1,300 words across 35 grammars, parsed by
both master and the PR branch with 0 divergences attributable to
PR #494. The one observed diff (edge-cases/truncate-morphotactic,
words `a`/`ga`) is pre-existing oracle nondeterminism in analysis
multiplicity ordering, reproducible on master alone, unrelated to the
syntactic FS change.

This was previously recorded only at tag archive/pr494-conformance;
folding it into the conformance suite's own PR (#480) so the evidence
travels with the suite it was run against. Fixed two references to
branches deleted since the doc was written (perf/pr494-conformance,
conformance/fieldworks-witnesses) to point at their preserved
archive/* tags instead; no other content changed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@johnml1135

Copy link
Copy Markdown
Collaborator Author

Added two independently justified conformance fixtures in a20bce1: final-template-partial-discriminators (10 words; #507) and template-category-sharing (6 words; #505). Fresh Release build: zero warnings/errors. Both fixtures pass with memoization on and off, zero skipped; 22 focused manifest/coverage tests pass. Four grammar counterfactuals produce the independently predicted mismatches, documented under conformance/docs. These are grammar-sensitivity controls, not proof that pruning, cache hits, or same-key feature collisions execute. No parser code changed. Generated inventory also restores previously omitted rows for the already-existing Exact-inverse fixture; its valid zudiua loss remains tracked in #504, not relabeled as correct.

@johnml1135

Copy link
Copy Markdown
Collaborator Author

Added the shared-template unconstrained-suffix conformance fixture in f150e2a. The grammar has a slot-only feature-unconstrained suffix shared by mandatory TV/IV templates, an ordinary N-to-IV verbalizer, four positive rows, and six rejection controls. The companion rationale explains complete forward derivations and loader reachability (not a FieldWorks UI round trip).

Fresh C# harness: all 10 rows pass in both template orders, memoization on/off (40 comparisons; no skips). Focused template/manifest tests: 22 passed, no skips. Regenerated manifest is current at 40 fixtures; coverage/rule reports updated. No Machine parser code changed.

PanGloss main now contains the narrow gate-only alignment (fc357daf), with this fixture mirrored unchanged until its old Machine submodule pin is upgraded. Direct state assertions provide red/green evidence; full-parse fixture checks pass both before and after the change. Issue #505 remains open for collision/correlation and broader merge-equivalence evidence.

johnml1135 added a commit that referenced this pull request Sep 26, 2026
Introduces an engine-agnostic conformance suite for HermitCrab-formalism
morphological parsers: a `conformance/` tree of language grammars and
edge-case micro-grammars, each an HC-XML grammar.xml paired with a
words.yaml ground truth (oracle-provenance, gloss, and per-word parse
signatures). A new SIL.Machine.Morphology.HermitCrab.Conformance project
and hc-conformance CLI tool run those fixtures against an engine adapter,
producing coverage and rules CSVs, an interface inventory, dataflow-
obligation ledgers, evidence cards, a FieldWorks-producibility table, and
a JSON manifest for external consumers. PROTOCOL.md is the adapter
contract a second engine (e.g. the in-progress Rust port) implements to
plug into the same suite.

Includes the FieldWorks-producibility classification campaign: for every
HermitCrab construct the suite covers, a verdict on whether FieldWorks'
own HC-XML export path can actually produce a grammar exercising it,
distinguishing genuine data-model limits from mere loader gaps, with five
previously-unresolved verdicts now classified and corrected write-ups for
two more cases initially misread as exporter silence.

Also lands one new edge-case fixture,
edge-cases/chained-output-feature-override-loss, isolating an analysis-
side OutputHeadFeatures retraction bug: a well-formed four-morph parse of
`zudiua` that the founding C# oracle currently loses. The fixture is
deliberately red against hc.dll today (expected, not a broken test) and
documents the mechanism, provenance, and the HC-Rust divergence that
motivated it.

The suite is deliberately stopped at this point rather than finished:
scope, known gaps, and next steps are documented in the suite's own
tracking docs rather than left implicit.

This commit squashes the full conformance-suite branch stack
(integrate-conformance-framework through conformance/fieldworks-
witnesses, 49 commits) into one commit on top of current master, for
PR #480.

Folds in three review fixes: AdapterEngine's contract in MaterializedRunner
now credits an expect_crash fixture only once the same engine also
completes an ordinary fixture from the same run, so a misconfigured
adapter (bad path, rejected arguments) can no longer register as
reproducing the pinned crash; GuesserSignatureTests' batch-path test is
renamed for the overload it actually calls; and .gitattributes freezes
project.fwdata as binary so its pinned SHA-256 is reproducible across
platforms and CI runners, not just this one.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@johnml1135
johnml1135 force-pushed the integrate-conformance-framework branch from 93f470c to 2933fcc Compare September 26, 2026 02:55
johnml1135 added a commit that referenced this pull request Sep 26, 2026
Records a break-attempt run of PR #494 (AnalysisAffixProcessRule fix)
against the conformance suite: 36/36 fixtures pass (including
pathological cases), and a generated-word fuzz sweep (every root x
every 0..3-subset of affix rules, up to 6 nonhead roots where the
grammar compounds) produced ~1,300 words across 35 grammars, parsed by
both master and the PR branch with 0 divergences attributable to
PR #494. The one observed diff (edge-cases/truncate-morphotactic,
words `a`/`ga`) is pre-existing oracle nondeterminism in analysis
multiplicity ordering, reproducible on master alone, unrelated to the
syntactic FS change.

This was previously recorded only at tag archive/pr494-conformance;
folding it into the conformance suite's own PR (#480) so the evidence
travels with the suite it was run against. Fixed two references to
branches deleted since the doc was written (perf/pr494-conformance,
conformance/fieldworks-witnesses) to point at their preserved
archive/* tags instead; no other content changed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
johnml1135 added a commit that referenced this pull request Sep 26, 2026
Introduces an engine-agnostic conformance suite for HermitCrab-formalism
morphological parsers: a `conformance/` tree of language grammars and
edge-case micro-grammars, each an HC-XML grammar.xml paired with a
words.yaml ground truth (oracle-provenance, gloss, and per-word parse
signatures). A new SIL.Machine.Morphology.HermitCrab.Conformance project
and hc-conformance CLI tool run those fixtures against an engine adapter,
producing coverage and rules CSVs, an interface inventory, dataflow-
obligation ledgers, evidence cards, a FieldWorks-producibility table, and
a JSON manifest for external consumers. PROTOCOL.md is the adapter
contract a second engine (e.g. the in-progress Rust port) implements to
plug into the same suite.

Includes the FieldWorks-producibility classification campaign: for every
HermitCrab construct the suite covers, a verdict on whether FieldWorks'
own HC-XML export path can actually produce a grammar exercising it,
distinguishing genuine data-model limits from mere loader gaps, with five
previously-unresolved verdicts now classified and corrected write-ups for
two more cases initially misread as exporter silence.

Also lands one new edge-case fixture,
edge-cases/chained-output-feature-override-loss, isolating an analysis-
side OutputHeadFeatures retraction bug: a well-formed four-morph parse of
`zudiua` that the founding C# oracle currently loses. The fixture is
deliberately red against hc.dll today (expected, not a broken test) and
documents the mechanism, provenance, and the HC-Rust divergence that
motivated it.

The suite is deliberately stopped at this point rather than finished:
scope, known gaps, and next steps are documented in the suite's own
tracking docs rather than left implicit.

This commit squashes the full conformance-suite branch stack
(integrate-conformance-framework through conformance/fieldworks-
witnesses, 49 commits) into one commit on top of current master, for
PR #480.

Folds in three review fixes: AdapterEngine's contract in MaterializedRunner
now credits an expect_crash fixture only once the same engine also
completes an ordinary fixture from the same run, so a misconfigured
adapter (bad path, rejected arguments) can no longer register as
reproducing the pinned crash; GuesserSignatureTests' batch-path test is
renamed for the overload it actually calls; and .gitattributes freezes
project.fwdata as binary so its pinned SHA-256 is reproducible across
platforms and CI runners, not just this one.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
johnml1135 added a commit that referenced this pull request Sep 26, 2026
Records a break-attempt run of PR #494 (AnalysisAffixProcessRule fix)
against the conformance suite: 36/36 fixtures pass (including
pathological cases), and a generated-word fuzz sweep (every root x
every 0..3-subset of affix rules, up to 6 nonhead roots where the
grammar compounds) produced ~1,300 words across 35 grammars, parsed by
both master and the PR branch with 0 divergences attributable to
PR #494. The one observed diff (edge-cases/truncate-morphotactic,
words `a`/`ga`) is pre-existing oracle nondeterminism in analysis
multiplicity ordering, reproducible on master alone, unrelated to the
syntactic FS change.

This was previously recorded only at tag archive/pr494-conformance;
folding it into the conformance suite's own PR (#480) so the evidence
travels with the suite it was run against. Fixed two references to
branches deleted since the doc was written (perf/pr494-conformance,
conformance/fieldworks-witnesses) to point at their preserved
archive/* tags instead; no other content changed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@johnml1135
johnml1135 force-pushed the integrate-conformance-framework branch from 2933fcc to f412c25 Compare September 26, 2026 04:15
johnml1135 added a commit that referenced this pull request Sep 30, 2026
Introduces an engine-agnostic conformance suite for HermitCrab-formalism
morphological parsers: a `conformance/` tree of language grammars and
edge-case micro-grammars, each an HC-XML grammar.xml paired with a
words.yaml ground truth (oracle-provenance, gloss, and per-word parse
signatures). A new SIL.Machine.Morphology.HermitCrab.Conformance project
and hc-conformance CLI tool run those fixtures against an engine adapter,
producing coverage and rules CSVs, an interface inventory, dataflow-
obligation ledgers, evidence cards, a FieldWorks-producibility table, and
a JSON manifest for external consumers. PROTOCOL.md is the adapter
contract a second engine (e.g. the in-progress Rust port) implements to
plug into the same suite.

Includes the FieldWorks-producibility classification campaign: for every
HermitCrab construct the suite covers, a verdict on whether FieldWorks'
own HC-XML export path can actually produce a grammar exercising it,
distinguishing genuine data-model limits from mere loader gaps, with five
previously-unresolved verdicts now classified and corrected write-ups for
two more cases initially misread as exporter silence.

Also lands one new edge-case fixture,
edge-cases/chained-output-feature-override-loss, isolating an analysis-
side OutputHeadFeatures retraction bug: a well-formed four-morph parse of
`zudiua` that the founding C# oracle currently loses. The fixture is
deliberately red against hc.dll today (expected, not a broken test) and
documents the mechanism, provenance, and the HC-Rust divergence that
motivated it.

The suite is deliberately stopped at this point rather than finished:
scope, known gaps, and next steps are documented in the suite's own
tracking docs rather than left implicit.

This commit squashes the full conformance-suite branch stack
(integrate-conformance-framework through conformance/fieldworks-
witnesses, 49 commits) into one commit on top of current master, for
PR #480.

Folds in three review fixes: AdapterEngine's contract in MaterializedRunner
now credits an expect_crash fixture only once the same engine also
completes an ordinary fixture from the same run, so a misconfigured
adapter (bad path, rejected arguments) can no longer register as
reproducing the pinned crash; GuesserSignatureTests' batch-path test is
renamed for the overload it actually calls; and .gitattributes freezes
project.fwdata as binary so its pinned SHA-256 is reproducible across
platforms and CI runners, not just this one.

Also folds in the follow-up PR commits: fuzz/break-attempt evidence;
admitting PCRE.NET's source generator via a vetted content-hash allowlist;
final-template and template-sharing controls; oracle-verified fixtures for
per-piece environments, simultaneous mode and iterative epenthesis;
reduplication x phonology cases; and a regenerated manifest, ledgers and
evidence cards.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@johnml1135
johnml1135 force-pushed the integrate-conformance-framework branch from f412c25 to d8ff628 Compare September 30, 2026 20:29
Comment thread local_check.sh Resolved
Comment thread eng/HcRoslynCompilerReferences.props Resolved
…52 fixtures, of which 46 list no morphological rule and 6 list one or more.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@claude

This comment has been minimized.

johnml1135 and others added 21 commits November 1, 2026 07:46
…eclare unordered, which the C# oracle shows changes no word's analyses.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…no longer do, and the C# oracle's rows are unchanged for all 137 runs.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ry without a part of speech, its slot rule as an ordinary suffix, and its partial rule without an outputPartOfSpeech, with napmo and pogliti still pinning both partial flags.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… rule has an outputPartOfSpeech, a stratum that lists morphological rules is not unordered, or a partial entry or rule has a shape HCLoader cannot write.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…slot-rule outputs and partial shapes are producible and which test enforces it.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…hologicalRule.outputPartOfSpeech witness rows, kulmo's renamed signature, and the linear surface evidenced only by standalone-combining-mark.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…xtures' figures: 1443 grammar-ledger rows, 1125 witness rows, 11 contradicted claims, and 29 open debt rows now that two unordered strata close their compounding pairs.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…d: no history, no document pointers, within the block budget.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ar stratum holds a listed rule or an active affix template, and standalone-combining-mark, the one fixture that did, says unordered.

The engine reads the stratum order when it applies templates as well as for listed rules, so PROTOCOL.md, the retirement record and the order measurement now say both, with the counts recomputed: 52 linear strata at 6b36f45, 7 now unordered, 45 holding neither rules nor templates. The partial-shape header of morphotactic-attribute-breadth states what napmo and pogliti pin and no longer narrates the rename.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…selines now describe standalone-combining-mark as unordered: the linear value is written by no fixture, so it is a dtd-default baseline line and no longer open coverage debt.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… when a fixture directory is missing from it, listed twice, or listed but gone.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…s a FieldWorks project can produce, and lists each construct the XML can say but HCLoader never writes, why, and which of the 27 retired fixtures needed it.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…at explained why it was not checked is gone with it.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ch fixture, the construct that disqualified it and what it tested, with no pointer to where the fixtures live.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… the FieldWorks-producible rule, the steps for a fixture, the generators and hand-edited files, the witness rules and the checks to run before pushing.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…grammar commit or the #480 component, keeping only the assembly hashes the measurements used.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…roducible, and rows 19 to 21 add foot features, ExcludedEnvironments and blockable=false, with the retirement table, the doubts and protocol section 9 matching.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…, reads the metathesis-reversal switch order as FieldWorks writes it, defines plain and zero, and describes each of the 35 alpha-family fixtures in a line.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…e flag, says to stage a deliberate regeneration before the git diff check, and gives the measured test-project time.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ducibility ledger wraps at the line limit and counts rows 19 to 21.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
{
string root = RepositoryRoot();
var fixtures = Fixture.DiscoverAll(Path.Combine(root, "conformance"));
fixtures.AddRange(Fixture.DiscoverAll(Path.Combine(root, "conformance-stress")));

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: F45. This line scans conformance-stress, which exists nowhere in this repository (a tree-wide grep finds only this line and the comment above it), so after merge it is dead code. The comment at line 33 explains it by "the branches that carry it", a pointer outside this tree. Drop both lines, or have DiscoverProducible read only conformance.

@claude

claude Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor
  1. Verdict: approve. The 22 commits since 6b36f45 add two test files, the conformance/AGENTS.md guide, and fixture conversions with regenerated ledgers. None of it reopens an earlier finding.
  2. What matters most: F45 (Low), FieldWorksProducibleShapeTests.cs:38. The new producibility test also scans conformance-stress, a directory that exists nowhere in this repository, and its comment points at other branches.
  3. Counts: 1 new Low (F45). Of 45 total, 4 are Critical, 8 Important and 33 Low; only F45 is open.
  4. What I ran:
    • gh pr checks 480: both Conformance suite runs and both comment-hygiene reports pass. Build on ubuntu-22.04 and windows-latest are pending.
    • dotnet test tests/SIL.Machine.Morphology.HermitCrab.Tests -c Release filtered to FieldWorksProducibleShapeTests, GrammarsOverviewTests, ConstructClaimCorroborationTests, GrammarCoverageLedgerTests, InterfaceWitnessLedgerTests, ConformanceFixtureGate and ConformanceManifestTests: 43 passed, 0 failed.
    • I read the src//tests/ diff since 6b36f45 and compared the new linear-stratum check with XmlLanguageLoader.LoadStratum. Both read only the stratum's own active definitions, so they agree.
    • I checked that every CLI flag conformance/AGENTS.md names exists in Program.cs, and that ConformanceFixtureGateTests.cs:258 enforces fieldworks_producible: true as that guide claims.
    • I did not run /code-review, because the code delta is two test files.
  5. What I could not verify:
    • the claim that the C# oracle's rows are unchanged for all 137 runs after the outputPartOfSpeech and unordered conversions, beyond the self-check passing at this head;
    • the [Explicit] ledger freshness tests, which take tens of minutes;
    • the HCLoader producibility verdicts in the README table, which come from FieldWorks source that is not in this tree.

Public API, target framework, package, or sillsdev/machine.py parity: None verified.

Finding Severity Status
F1 Critical addressed (cc947db)
F2 Important addressed (bcb3d62)
F3 Important addressed (bcb3d62)
F4 Important accepted, unverified
F5 Low addressed (bcb3d62)
F6 Low addressed (067de6f)
F7 Low addressed (0a1212b)
F8 Low addressed (067de6f)
F9 Low addressed (067de6f)
F10 Important addressed (cd0c909)
F11 Low accepted, unverified
F12 Low addressed (cd0c909)
F13 Low addressed (0a1212b)
F14 Low addressed (0a1212b)
F15 Low addressed (067de6f)
F16 Low addressed (067de6f)
F17 Low addressed (0a1212b)
F18 Low addressed (0a1212b)
F19 Critical addressed (e7fe733)
F20 Low addressed (8b5d74e)
F21 Low addressed (1c5c3a5)
F22 Low addressed (a3b4c0e)
F23 Important addressed (49ba481)
F24 Important addressed (49ba481)
F25 Low addressed (9671b28)
F26 Low addressed (641f613)
F27 Low addressed (8b5d74e)
F28 Critical addressed (dd5f00f, 2cd68e8)
F29 Low addressed (bb42ff4)
F30 Low addressed (f592706)
F31 Low addressed (6c6fbb3)
F32 Critical addressed (cf84539, stacked on #500 and #556)
F33 Low addressed (b9c7c8a)
F34 Low addressed (382168a)
F35 Important addressed (9d7963a)
F36 Low addressed (19a2979)
F37 Low addressed (19a2979)
F38 Important addressed (b84c578)
F39 Low addressed (ec897fa, 6e1155f)
F40 Low addressed (d1f545c)
F41 Low addressed (1358310)
F42 Low addressed (e21aae4, fixture retired)
F43 Low addressed (e21aae4, fixture retired)
F44 Low addressed (6b36f45)
F45 Low new

Reviewed at 69c4ee0

@johnml1135 johnml1135 closed this Nov 2, 2026
johnml1135 added a commit to sillsdev/fieldworks-parser-conformance that referenced this pull request Nov 3, 2026
… the wrapper script.

Removes the machine commit hash, the "last copy" wording and the sillsdev/machine#615 mentions
that the previous commit added, and returns PROVENANCE.md to its content on main. The
consumer-pin corrections stay.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
johnml1135 added a commit to sillsdev/PanGloss that referenced this pull request Nov 5, 2026
…the #18 waivers are gone (#184)

* Align truncation morph attribution with corrected C# semantics

Replay copied annotation transfers before the zero-width last-node claim.
Preserve current node ownership, genuine descendant grouping and repeated
allomorph suppression using existing flat morph records and shared decoded
ranges. Keep compound descendant transfer non-recursive, matching C#.

Reuse the #480 identity, subsumption and copy-U fixtures with complete
occurrence and application histories. Add the root-boundary regression and
stage the existing #553 partial-root corpus with separate prune counters.

References: sillsdev/machine#500, sillsdev/machine#506,
sillsdev/machine#556, sillsdev/machine#480, sillsdev/machine#553.

* test: register new parser modules in harness inventory

* Match the pinned oracle on truncation identities and remove obsolete waivers.

Drop graduated fixture copies and remove the five-word and shell-runner
exceptions. Ratchet measured faithfulness failures from 24 to 11 and expose
the corrected ground truth's tuned-surface proposal gap in the scoreboard.

Co-Authored-By: Codex GPT-6.1 Sol <noreply@openai.com>

* Restore pruning coverage and document truncation proposal identities.

Count both template skip mechanisms in the clitic-state guard. Pin a
Floating annotation's later anchor-copy transition with real synthesis.
Explain the HC-Rust dependency of scoreboard ground truth and composite
FST proposal tags using before/after gau identities.

Co-Authored-By: Codex GPT-6.1 Sol <noreply@openai.com>

---------

Co-authored-by: Codex GPT-6.1 Sol <noreply@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants