Skip to content

Remove the noscript pixel from the SRI embed script - #92

Merged
adriaandotcom merged 1 commit into
masterfrom
docs/update-sri-hash
Nov 16, 2026
Merged

adriaandotcom merged 1 commit into
masterfrom
docs/update-sri-hash

Conversation

@simpleanalytics-agent

@simpleanalytics-agent simpleanalytics-agent commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Closes #91

Removes the <noscript> pixel from the embed script on the SRI page. The integrity hashes are unchanged because they still match the live script.

 <script async src="https://scripts.simpleanalyticscdn.com/sri/v12.js" integrity="sha256-… sha384-… sha512-…" crossorigin="anonymous"></script>
-<noscript><img src="https://queue.simpleanalyticscdn.com/noscript.gif" alt="" referrerpolicy="no-referrer-when-downgrade" /></noscript>

Evidence

  • Hashes: these are the hashes of https://scripts.simpleanalyticscdn.com/sri/v12.js, and they match the page's sriHash:
    sha256-iSFbgQEAJgoeLh+lTWPVLouX2RiBERlq4qAOgM8aK+g=
    sha384-VVOeJV8okLf6owAyITVK14p3AX78fPOStksa5tYEruAngS4yv5EYM26KP9bvcZ/L
    sha512-DrEJKCUTeTeOenmoMwQa6d3KSiKXCFdZjjbsJhzh4vYFXPxjoU8dfd8oISmIDqrkkRYeCriuEC5TEah3aONxsg==
    
    v12 is the latest scripts release, and sri/v13.js returns 404. The CDN file matches dist/v12/app.js in the v12 release except for the source-map filename, which the deploy step renames.
  • Before: the code block in the built _site/sri.html shows the script and the noscript.gif pixel.
    After: jekyll build succeeds, and the code block shows only the script with the same hashes. The page's only remaining noscript.gif is the docs site's own tracking tag from _layouts/default.html.

Security implications

  • No security impact
  • Has security impact - described as:

Merge Danger

Door: two-way

Blast Radius: one page

New SRI installs copied from this page won't include the pixel, so they won't record page views from visitors without JavaScript. Existing installs are unaffected.

Summary by CodeRabbit

  • Documentation
    • The SRI embed example now shows only the script tag; the <noscript> image fallback has been removed.

The pixel has nothing to do with SRI and mostly records bots. The
published hashes still match sri/v12.js on the CDN.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The SRI embed example removes the <noscript> image fallback. The example now shows only the script tag.

Changes: SRI embed example

Layer / File(s) Summary
Update the SRI embed example
_docs/20_install-script/19_sri.md
The example removes the <noscript> image fallback that followed the script tag.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: adriaandotcom

Merge Risk: Minimal · up to 079ee

This is a documentation-only change that removes the noscript pixel from the SRI embed example, as requested. Existing installs are unaffected. It is safe to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "Remove the noscript pixel from the SRI embed script" matches the only change in the changeset. The raw summary shows that the SRI embed example in _docs/20_install-script/19_sri.md no longe…
Linked Issues check Passed Issue #91 asks to remove the <noscript> pixel from the SRI embed script on the SRI page. The whole-PR diff (merge base a25857a to head 079eec7) removes exactly that line from `_docs/20_install-scr…
Out of Scope Changes check Passed The only change in the whole PR is the one-line removal of the <noscript> pixel from _docs/20_install-script/19_sri.md. This is the file and element named in #91. No other install pages are modifi…
Full details: Title check

Explanation

The title "Remove the noscript pixel from the SRI embed script" matches the only change in the changeset. The raw summary shows that the SRI embed example in _docs/20_install-script/19_sri.md no longer includes the noscript image fallback, leaving only the script tag. The objectives confirm the same scope: removing the noscript tracking pixel from the SRI page embed example, with the integrity hashes unchanged. The title is specific, concise, and describes the primary change.

Full details: Linked Issues check

Explanation

Issue #91 asks to remove the &lt;noscript&gt; pixel from the SRI embed script on the SRI page. The whole-PR diff (merge base a25857a to head 079eec7) removes exactly that line from _docs/20_install-script/19_sri.md. The embed block now contains only the &lt;script async src=".../sri/v{{ page.sriVersion }}.js" integrity="{{ page.sriHash }}" crossorigin="anonymous"&gt; tag. The diff does not change sriHash or sriVersion. The hash check in #91 is a verification step. The author reports that the hashes match sri/v12.js. The repository tools cannot fetch the live CDN file, so the hash match is not independently verified here. No code change is needed for that step unless the hashes differ. The coding requirement is met.

Full details: Out of Scope Changes check

Explanation

The only change in the whole PR is the one-line removal of the &lt;noscript&gt; pixel from _docs/20_install-script/19_sri.md. This is the file and element named in #91. No other install pages are modified. The issue explicitly excludes other install pages that show the pixel, and this PR leaves them unchanged. No unrelated changes were found.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: QUIET
  • Plan: Team
  • Run ID: 0b08ca5d-ac51-4148-b32e-09912ab74692
Commits

Reviewing files that changed from the base of the PR and between a25857a and 079eec7.

Files selected for processing: 1

  • _docs/20_install-script/19_sri.md
Files with no reviewable changes: 1

  • _docs/20_install-script/19_sri.md

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour.

@github-actions github-actions Bot added the change: routine Routine or ordinary change that needs at most one human or AI-assisted review label Nov 16, 2026
@github-actions

Copy link
Copy Markdown

SDLC label: change: routine because The change removes a noscript tracking-pixel snippet from a public documentation page, which is a static docs site and always routine, so no one's data access or production behavior is affected.

@adriaandotcom
adriaandotcom merged commit 232ee8d into master Nov 16, 2026
2 checks passed
@adriaandotcom
adriaandotcom deleted the docs/update-sri-hash branch November 16, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change: routine Routine or ordinary change that needs at most one human or AI-assisted review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SRI embed script includes the noscript pixel

2 participants