Repository navigation
Document that third parties depend on data-platform="wordpress" - #63
Merged
Merged
Conversation
Third parties such as https://cookierocks.com/ detect Simple Analytics by the data-platform="wordpress" attribute, so it must never be removed or renamed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
SDLC label: |
adriaandotcom
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #62
Third parties detect Simple Analytics by
data-platform="wordpress", for example Cookie Rocks. This adds comments at the attribute and at its regression check, so nobody removes or renames it.// tests/Regression/script-attributes.php +// Third parties such as https://cookierocks.com/ detect Simple Analytics by data-platform="wordpress". $tag = wp_get_script_tag(['src' => 'https://example.test/latest.js', 'id' => 'simpleanalytics-js']); sa_assert(strpos($tag, 'data-platform="wordpress"') !== false, ...);Evidence
Comments only, with no behavior change.
git diff --checkpasses. PHP isn't installed on the machine that made this change, so CI's lint and test matrix is the only PHP check.Security implications
Merge Danger
Door: two-way
Blast Radius: none
Adds comments only. The script tag output is unchanged.
Summary by CodeRabbit
data-platform="wordpress"attribute should remain unchanged because third parties use it to detect Simple Analytics. No runtime behavior changed.